Skip to content

Commit ec5710d

Browse files
author
gregn
committed
Fix: GH-5 Hardcoded instance types
1 parent 485cfa2 commit ec5710d

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

LINUX/AS2-Automation-Linux-CloudFormation.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ Parameters:
2323
Type: String
2424
Description: Default Linux image to use when creating the AppStream 2.0 image builder instance. Input the name of your customized image with the embedded SSH key here. See blog documentation for instructions on creating this.
2525
Default: Linux_Automation_Base
26+
AS2DefaultInstanceType:
27+
Type: String
28+
Description: The AppStream Instance type to use for the ImageBuilder
29+
Default: 'stream.standard.medium'
2630
AS2DefaultSSHKeyARN:
2731
Type: String
2832
Description: ARN of the AWS Systems Manager parameter containing the SSH key embedded in your customized Linux image. See blog documentation for instructions on creating this. (arn:aws:ssm:us-east-2:123456789012:parameter/as2_automation/rsakey)
@@ -434,9 +438,9 @@ Resources:
434438
Ref: ImageBuilderSecurityGroup
435439
Default_Subnet :
436440
Ref: AS2VPCSubnet1
437-
Default_Type : stream.standard.medium
438441
Default_ImageBuilderSSHKeyARN :
439442
Ref: AS2DefaultSSHKeyARN
443+
Default_Type : !Ref AS2DefaultInstanceType
440444
Runtime: python3.9
441445
Role: !GetAtt 'LambdaFunctionIAMRole.Arn'
442446
Timeout: 30

WINDOWS/AS2-Automation-Windows-CloudFormation.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ Parameters:
2323
Type: String
2424
Description: Default Windows image to use when creating the AppStream 2.0 image builder instance. For non-domain joined image builders, input your customized base image with the embedded startup script here. See blog documentation for instructions on creating this.
2525
Default: AppStream-WinServer2019-03-03-2022
26+
AS2DefaultInstanceType:
27+
Type: String
28+
Description: The AppStream Instance type to use for the ImageBuilder
29+
Default: 'stream.standard.medium'
2630
DefaultDomain:
2731
Type: String
2832
Description: Default Active Directory FQDN to join image builder instances to. This should already be setup within the AppStream 2.0 console. Leave blank or enter 'none' to not join a domain. (onprem.corp.int)
@@ -524,8 +528,8 @@ Resources:
524528
Ref: ImageBuilderSecurityGroup
525529
Default_Subnet :
526530
Ref: AS2VPCSubnet1
527-
Default_Type : stream.standard.medium
528531
Default_S3_Bucket: !Ref WorkShopS3Bucket
532+
Default_Type : !Ref AS2DefaultInstanceType
529533
Runtime: python3.9
530534
Role: !GetAtt 'LambdaFunctionIAMRole.Arn'
531535
Timeout: 30

0 commit comments

Comments
 (0)