Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access log bucket creation fails during deployment #9

Closed
steveaitch opened this issue May 26, 2023 · 5 comments
Closed

Access log bucket creation fails during deployment #9

steveaitch opened this issue May 26, 2023 · 5 comments

Comments

@steveaitch
Copy link

Since the April changes to S3 bucket public access and ACLs, deployment now fails when creating serverAccessLogsBucket in pipeline-stack.ts and serverAccessLoggingBucket in doctran-stack.ts, giving "Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting" errors.

I have fixed this by adding objectOwnership: s3.ObjectOwnership.OBJECT_WRITER, to the properties when creating these buckets.

This is with version 1.1.3.

@philipws
Copy link
Contributor

philipws commented Jun 6, 2023

Hey @steveaitch thanks for raising this with us. I will take a look into it.

@philipws
Copy link
Contributor

philipws commented Jun 8, 2023

Thank you @steveaitch this has been resolved on the latest release. https://github.com/aws-samples/document-translation/releases/tag/v1.1.4

Upstream CDK related issue: aws/aws-cdk#25288

@philipws philipws closed this as completed Jun 8, 2023
@giordafrancis
Copy link

I'm commenting here as I've experienced a similar deployment error and I've noticed this issue is now closed . When attempting to deploy the app I face the below error:

Resource handler returned message: "Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting (Service: S3, Status Code: 400,

I've the latest version of the repo and both serverAccessLoggingBucket and serverAccessLogsBucket have the Object Ownership set to OBJECT_WRITER which should prevent this deployment issue.

Any idea on what is potential triggering the deployment error?

@philipws
Copy link
Contributor

Hey @giordafrancis I believe I was asked about this by your AWS SA and it's been resolved. Can you confirm that's the case? (Or I've gotten you mixed up with someone else.

@giordafrancis
Copy link

giordafrancis commented Jun 14, 2024

Hey @giordafrancis I believe I was asked about this by your AWS SA and it's been resolved. Can you confirm that's the case? (Or I've gotten you mixed up with someone else.

Yes! Thank you @philipws. It was me and now it's resolved. This was fixed by using the latest tag to date (v2.2.0) merging with main, and then deploying the stack. Also thank you for all the work you've put into the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants