Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbor URL chaining filters does not work since v4.2 #343

Closed
6 tasks
Furytron opened this issue Feb 25, 2022 · 7 comments
Closed
6 tasks

Thumbor URL chaining filters does not work since v4.2 #343

Furytron opened this issue Feb 25, 2022 · 7 comments
Assignees
Labels

Comments

@Furytron
Copy link

Describe the bug
Thumbor URLs cannot chain filters. in version 3.1.1 you could chain the filters, now since v4.2 you cannot chain them.
See Thumbor documentation, which has lots of examples of chained filters: https://thumbor.readthedocs.io/en/latest/filters.html#how-filters-work

If lots of filters are used, the URLs can become long and ugly.

To Reproduce

  1. In v3.1.1 you can use the following url: https://example.cloudfront.net/filters:grayscale():blur(20)/myimage.jpg
  2. Since v4.2 you cannot use the following url: https://example.cloudfront.net/filters:grayscale():blur(20)/myimage.jpg, the URL must be: https://example.cloudfront.net/filters:grayscale()/filters:blur(20)/myimage.jpg. Where there is the text "filters:" for each filter.

Expected behavior
Should support chaining the filters: /filters:grayscale():blur(20):rotate(90)/.
Since changes this may break existing filters, you will likely need to support both chaining filters, and the current broken way.
It is still broken in v6.0.

Please complete the following information about the solution:

  • Version: v4.2
  • Region: all
  • Was the solution modified from the version published on this repository?
  • If the answer to the previous question was yes, are the changes available on GitHub?
  • Have you checked your service quotas for the sevices this solution uses?
  • Were there any errors in the CloudWatch Logs?

Screenshots
Working image, without chained filters:
image
Not working image, with chained filters
image

Additional context
This is an issue that was already logged but mistakenly closed: #187

@Furytron Furytron added the bug label Feb 25, 2022
@fisenkodv
Copy link
Contributor

@Furytron thank you for your feedback. We will look into it and add it to our backlog.

@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@Furytron
Copy link
Author

keep open

@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the Stale label Dec 21, 2022
@Furytron
Copy link
Author

Keep open... again

@github-actions github-actions bot removed the Stale label Dec 22, 2022
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@dougtoppin
Copy link
Contributor

addressed with v6.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants