Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTO_WEBP option to automatically serve WebP if the client supports it #152

Closed
wants to merge 1 commit into from

Conversation

browniebroke
Copy link

Fixes #99

Description of changes:

This adds back the AUTO_WEBP option that was available in the Thumbor-based image handler, as requested in #99.

Took the diff from @soupy1976 in that issue and changed it a little bit to make it configurable by environment variable. The function is also called getOutputFormat so it could be reused for other things.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Flythe
Copy link

Flythe commented Nov 6, 2019

The template for the CloudFront deployment is set up to not forward the Accept headers (see line 103). You can add them with "Headers": [ "Origin", "Accept" ].

@beomseoklee
Copy link
Member

Thanks for your effort here, @browniebroke
We have updated our solution, and your pull request has been merged into our master branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here

@browniebroke
Copy link
Author

Confirmed that it's now in master, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic WebP support
3 participants