Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a non breaking change, already tested and working in a production environment.
The ALB lambda integration is not well documented..
I Had to remove the
Access-Control-Allow-Credentials
header when the request is coming from an ALB because it was returning 502 when I tried with that header.Also i found out(via test and errors) that the order of the returned object does matter as
isBase64Encoded
must be before the body, if it is not.This should save the user the $3.5 per 1M if he does not need more features from APIGW, and it does also works with Cloudfront.
With this PR it will continue to work with APIGW without changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.