Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpg magic number FFD8FFE2 #489

Conversation

TheInfiniteBarnaby
Copy link

Extend JPG magic numbers to include FFD8FFE2, and extend tests to cover other magic number cases.

Issue #, if available:
Addresses: #484

Description of changes:
Extend valid magic numbers for JPG format to include FFD8FFE2.

Checklist

  • 👋 I have added unit tests for all code changes.
  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Barnaby Mercer added 3 commits July 4, 2023 12:31
Extend JPG magic numbers to include FFD8FFE2
Generalise tests for other magic numbers
Generalise tests for other magic numbers
@simonkrol simonkrol self-requested a review July 4, 2023 16:32
Copy link
Member

@simonkrol simonkrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fjool,
I'm a fan of the change to cleanup the unit test while increasing coverage.

We've added the inclusion of this change to our backlog and will get back to you after verification.

Thanks,
Simon

@simonkrol simonkrol mentioned this pull request Nov 14, 2023
6 tasks
@dorrikh dorrikh requested a review from dougtoppin November 21, 2023 04:23
@dougtoppin
Copy link
Contributor

addressed in v6.2.4

@dougtoppin dougtoppin closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants