Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enable static code quality checks #209

Closed
asarkar opened this issue Oct 19, 2022 · 1 comment
Closed

[BUG] Enable static code quality checks #209

asarkar opened this issue Oct 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@asarkar
Copy link
Contributor

asarkar commented Oct 19, 2022

Acceptance Criteria

  1. While making the PR Refactor for publishing to Maven Central #208, I disabled the static code quality checks. These should be enabled again.
    2. Removing the hard-coded checkstyle version (thus using the default version in the checkstyle plugin) causes the build to fail. We should not be dependent on a specific checkstyle version. This issue can be reproduced by using version 8.45.1 (default as of today)
* What went wrong:
Execution failed for task ':checkstyleMain'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
   > Unable to create Root Module: config {/some/path/amazon-neptune-jdbc-driver/config/checkstyle/checkstyle.xml}, classpath {null}.
@asarkar asarkar added the bug Something isn't working label Oct 19, 2022
@asarkar
Copy link
Contributor Author

asarkar commented Oct 19, 2022

Removing the hard-coded checkstyle version (thus using the default version in the checkstyle plugin) causes the build to fail.

Fixed by #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants