Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env vars, configuration should be initialized once #419

Closed
nckturner opened this issue Apr 26, 2019 · 2 comments
Closed

Env vars, configuration should be initialized once #419

nckturner opened this issue Apr 26, 2019 · 2 comments
Labels
good first issue tech debt

Comments

@nckturner
Copy link
Contributor

There is logic in ipamd that looks up environment variables in various places. (E.g. https://github.com/aws/amazon-vpc-cni-k8s/blob/master/ipamd/ipamd.go#L640) This should all be done during initialization, and stored in IPAMContext for referencing later.
@Zyqsempai
Copy link
Contributor

Looks interesting to me, i can take care of it.

@Zyqsempai Zyqsempai mentioned this issue May 3, 2019
Merged
@mogren
Copy link
Contributor

mogren commented May 28, 2019

Fixed by @Zyqsempai

@mogren mogren closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mogren @nckturner @Zyqsempai