Skip to content

Commit a837402

Browse files
committed
code review
1 parent 7faa06c commit a837402

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ protected <T, E extends Exception> PluginChainJdbcCallable<T, E> makePluginChain
278278
if (isSubscribed) {
279279
if (pluginChainFunc == null) {
280280
// This case is for DefaultConnectionPlugin that always terminates the list of plugins.
281-
// Default plugin couldn't be skipped.
281+
// Default plugin can't be skipped.
282282
pluginChainFunc = (pipelineFunc, jdbcFunc, pluginToSkip) ->
283283
executeWithTelemetry(() -> pipelineFunc.call(plugin, jdbcFunc), pluginName);
284284
} else {

wrapper/src/main/java/software/amazon/jdbc/plugin/federatedauth/FederatedAuthPlugin.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.checkerframework.checker.nullness.qual.NonNull;
3131
import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
3232
import software.amazon.awssdk.regions.Region;
33+
import software.amazon.jdbc.AuthenticationConnectionPlugin;
3334
import software.amazon.jdbc.AwsWrapperProperty;
3435
import software.amazon.jdbc.HostSpec;
3536
import software.amazon.jdbc.JdbcCallable;
@@ -47,7 +48,7 @@
4748
import software.amazon.jdbc.util.telemetry.TelemetryFactory;
4849
import software.amazon.jdbc.util.telemetry.TelemetryGauge;
4950

50-
public class FederatedAuthPlugin extends AbstractConnectionPlugin {
51+
public class FederatedAuthPlugin extends AbstractConnectionPlugin implements AuthenticationConnectionPlugin {
5152

5253
static final ConcurrentHashMap<String, TokenInfo> tokenCache = new ConcurrentHashMap<>();
5354
private final CredentialsProviderFactory credentialsProviderFactory;

0 commit comments

Comments
 (0)