Skip to content

Commit 32c0b68

Browse files
committed
chore: use non-caret dependency versions
Monorepo dependencies were using carets `^`; for most of these it didn't matter because the resulting artifact was bundled anyway, but for a couple it did matter: * `cdk -> aws-cdk`: should use the exact same version, otherwise running `npx cdk@2.1000` may accidentally execute `aws-cdk@2.1001`.
1 parent a139c52 commit 32c0b68

File tree

14 files changed

+42
-23
lines changed

14 files changed

+42
-23
lines changed

.projenrc.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ const cdkAssets = configureProject(
536536
description: 'CDK Asset Publishing Tool',
537537
srcdir: 'lib',
538538
deps: [
539-
cloudAssemblySchema,
539+
cloudAssemblySchema.customizeReference({ exactVersion: true }),
540540
cxApi,
541541
'archiver',
542542
'glob',
@@ -722,8 +722,8 @@ const cli = configureProject(
722722
'xml-js',
723723
],
724724
deps: [
725-
cloudAssemblySchema,
726-
cloudFormationDiff,
725+
cloudAssemblySchema.customizeReference({ exactVersion: true }),
726+
cloudFormationDiff.customizeReference({ exactVersion: true }),
727727
cxApi,
728728
'@aws-cdk/region-info',
729729
'archiver',
@@ -962,7 +962,7 @@ const cliLib = configureProject(
962962
entrypoint: 'lib/main.js', // Bundled entrypoint
963963
description: 'AWS CDK Programmatic CLI library',
964964
srcdir: 'lib',
965-
devDeps: ['aws-cdk-lib', cli, 'constructs'],
965+
devDeps: ['aws-cdk-lib', cli.customizeReference({ exactVersion: true }), 'constructs'],
966966
disableTsconfig: true,
967967
nextVersionCommand: `tsx ../../../projenrc/next-version.ts copyVersion:../../../${cliPackageJson} append:-alpha.0`,
968968
releasableCommits: transitiveToolkitPackages('@aws-cdk/cli-lib-alpha'),
@@ -1060,6 +1060,8 @@ const toolkitLib = configureProject(
10601060
srcdir: 'lib',
10611061
deps: [
10621062
cloudAssemblySchema,
1063+
// Purposely a ^ dependency so that clients selecting old toolkit library
1064+
// versions still might get upgrades to this dependency.
10631065
cloudFormationDiff,
10641066
cxApi,
10651067
'@aws-cdk/region-info',
@@ -1093,6 +1095,7 @@ const toolkitLib = configureProject(
10931095
'@smithy/util-waiter',
10941096
'archiver',
10951097
'camelcase@^6', // Non-ESM
1098+
// Purposely a ^ dependency so that clients get upgrades to this library.
10961099
cdkAssets,
10971100
'cdk-from-cfn',
10981101
'chalk@^4',
@@ -1305,7 +1308,7 @@ const cdkAliasPackage = configureProject(
13051308
name: 'cdk',
13061309
description: 'AWS CDK Toolkit',
13071310
srcdir: 'lib',
1308-
deps: [cli],
1311+
deps: [cli.customizeReference({ exactVersion: true })],
13091312
nextVersionCommand: `tsx ../../projenrc/next-version.ts copyVersion:../../${cliPackageJson}`,
13101313
releasableCommits: transitiveToolkitPackages('cdk'),
13111314
}),

package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/cdk-cli-wrapper/.projen/deps.json

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/cli-lib-alpha/.projen/deps.json

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/cli-lib-alpha/package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/toolkit-lib/.projen/deps.json

Lines changed: 7 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk/toolkit-lib/package.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-cdk/.projen/deps.json

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-cdk/package.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cdk-assets/.projen/deps.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)