fix(cli): cannot set progress via app or user configuration (#231)

In [v2.172.0](https://github.com/aws/aws-cdk/releases/tag/v2.172.0) (via
aws/aws-cdk@069b72c)
we accidentally broke the "bar" stack activity progress output mode (*).
Turns out no-one noticed.

In
[v2.1002.0](https://github.com/aws/aws-cdk-cli/releases/tag/aws-cdk%40v2.1002.0)
(via
0d9912f)
this got unintentionally fixed and the `--progress` was honored again.
However the accidental fix didn't consider options set by app or user
configuration. Again noone really noticed, until this week a user
alerted my to the issue on the cdk.dev Slack.

This PR fixes `progress` set via app or user configuration.

(*) This line is the culprit:

aws/aws-cdk@069b72c#diff-d03bd87f399ba5824d5442aa691df8b6f08f4f8a3848cfc8492c3d52fab5e48bR105
Previously "default" verbosity was a `0`, which meant `verbose = 0` and
later on `!verbose` would turn into `true`.
The change caused `verbose` to be a value different than `0` and thus
turning `!verbose` to be `false` and the code would always assume we are
in verbose logging mode and must use the "events" progress.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

Author: mrgrain

packages/aws-cdk/lib/cli/cdk-toolkit.ts

@@ -294,6 +294,11 @@ export class CdkToolkit {
       return this.watch(options);
     }
 
+    // set progress from options, this includes user and app config
+    if (options.progress) {
+      this.ioHost.stackProgress = options.progress;
+    }
+
     const startSynthTime = new Date().getTime();
     const stackCollection = await this.selectStacksForDeploy(
       options.selector,
@@ -760,6 +765,11 @@ export class CdkToolkit {
   public async import(options: ImportOptions) {
     const stacks = await this.selectStacksForDeploy(options.selector, true, true, false);
 
+    // set progress from options, this includes user and app config
+    if (options.progress) {
+      this.ioHost.stackProgress = options.progress;
+    }
+
     if (stacks.stackCount > 1) {
       throw new ToolkitError(
         `Stack selection is ambiguous, please choose a specific stack for import [${stacks.stackArtifacts.map((x) => x.id).join(', ')}]`,

packages/aws-cdk/test/cli/cdk-toolkit.test.ts

@@ -97,6 +97,7 @@ import {
   restoreSdkMocksToDefault,
 } from '../util/mock-sdk';
 import { asIoHelper } from '../../../@aws-cdk/tmp-toolkit-helpers/src/api/io/private';
+import { StackActivityProgress } from '../../lib/commands/deploy';
 
 markTesting();
 
@@ -615,7 +616,6 @@ describe('deploy', () => {
     expect(mockSynthesize).not.toHaveBeenCalled();
   });
 
-
   describe('readCurrentTemplate', () => {
     let template: any;
     let mockCloudExecutable: MockCloudExecutable;
@@ -1009,6 +1009,36 @@ describe('deploy', () => {
       );
     });
   });
+
+  test('can set progress via options', async () => {
+    const ioHost = CliIoHost.instance();
+
+    // Ensure environment allows StackActivityProgress.BAR
+    ioHost.stackProgress = StackActivityProgress.BAR;
+    ioHost.isTTY = true;
+    ioHost.isCI = false;
+    expect(ioHost.stackProgress).toBe('bar');
+
+    const toolkit = new CdkToolkit({
+      ioHost,
+      cloudExecutable,
+      configuration: cloudExecutable.configuration,
+      sdkProvider: cloudExecutable.sdkProvider,
+      deployments: new FakeCloudFormation({}),
+    });
+
+    // check this hasn't changed yet
+    expect(ioHost.stackProgress).toBe('bar');
+
+    await toolkit.deploy({
+      progress: StackActivityProgress.EVENTS,
+      selector: { patterns: ["**"] },
+      hotswap: HotswapMode.FALL_BACK
+    });
+
+    // now expect it to be updated
+    expect(ioHost.stackProgress).toBe('events');
+  });
 });
 
 describe('destroy', () => {