Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct library pattern for metrics #229

Closed
10 tasks
eladb opened this issue Apr 15, 2019 · 1 comment
Closed
10 tasks

Construct library pattern for metrics #229

eladb opened this issue Apr 15, 2019 · 1 comment
Labels
status/stale The RFC did not get any significant enough progress or tracking and has become stale.

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019

  • Productize metric code generation
    • Move the source model to L2 (from cfnspec)
    • Consider Smithy as a source format for the model
    • support static "all" metrics and update guidelines
  • Add metric to cdk.IResource
  • Implement and apply rule awslint:metrics-on-interface: All metric methods should be on the construct interface and not the class
  • Implement and apply rule awslint:metrics-generic-method: All constructs which emit metrics should have at least a single generic "metric" method
  • Implement and apply rule awslint:metrics-method-signature: Metric method signature should adhere to the rules
  • Implement and apply rule awslint:metrics-static-all-generic: If there is a static all metric method, it should at least include a single "metricAll" generic method
  • Implement and apply rule awslint:metrics-static-all: Verify signature of all "metricAllXxx" static methods
@eladb eladb changed the title Guidelines implementation: Metrics awslint:metrics May 1, 2019
@eladb eladb changed the title awslint:metrics Construct library pattern for metrics Jan 23, 2020
@rix0rrr rix0rrr closed this as completed Mar 3, 2020
@rix0rrr rix0rrr reopened this Mar 3, 2020
@eladb eladb transferred this issue from aws/aws-cdk Aug 17, 2020
@nija-at nija-at added the status/proposed Newly proposed RFC label Nov 11, 2020
@eladb eladb removed their assignment Feb 25, 2021
@mrgrain
Copy link
Contributor

mrgrain commented Oct 27, 2023

Marking this RFCs as stale since there has been little recent activity and it is not currently close to getting accepted as-is. We appreciate the effort that has gone into this proposal. Marking an RFCs as stale is not a one-way door. If you have made substantial changes to the proposal, please open a new issue/RFC. You might also consider raising a PR to aws/aws-cdk directly or self-publishing to Construct Hub.

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@mrgrain mrgrain added status/stale The RFC did not get any significant enough progress or tracking and has become stale. and removed status/proposed Newly proposed RFC labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale The RFC did not get any significant enough progress or tracking and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants