Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct library pattern for resources that need IAM roles #232

Closed
5 tasks
eladb opened this issue Apr 15, 2019 · 1 comment
Closed
5 tasks

Construct library pattern for resources that need IAM roles #232

eladb opened this issue Apr 15, 2019 · 1 comment
Labels
status/stale The RFC did not get any significant enough progress or tracking and has become stale.

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019

  • Implement and apply rule awslint:role-config-prop: If the CloudFormation resource has a "Role" property the construct must have an optional "role: IRole" prop
  • Implement and apply rule awslint:role-property: Constructs with a role should have a "readonly role: IRole" property on their construct interface
  • Implement and apply rule awslint:role-add-to-policy: Constructs with a role must have an "addToRolePolicy" method on the construct interface
  • Implement and apply rule awslint:resource-policy-prop: The "resourcePolicy" prop should be optional and accept an array of PolicyStatements
  • Implement and apply rule awslint:resource-policy-add-to-policy: Constructs that have a resource policy should have an addToResourcePolicy method on their interface
@eladb eladb changed the title Guidelines implementation: Roles awslint:role May 1, 2019
@eladb eladb changed the title awslint:role Construct library pattern for resources that need IAM roles Jan 23, 2020
@eladb eladb transferred this issue from aws/aws-cdk Aug 17, 2020
@eladb eladb removed their assignment Feb 25, 2021
@eladb eladb added the status/proposed Newly proposed RFC label Mar 11, 2021
@mrgrain mrgrain added status/stale The RFC did not get any significant enough progress or tracking and has become stale. and removed status/proposed Newly proposed RFC labels Oct 27, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Oct 27, 2023

Marking this RFCs as stale since there has been little recent activity and it is not currently close to getting accepted as-is. We appreciate the effort that has gone into this proposal. Marking an RFCs as stale is not a one-way door. If you have made substantial changes to the proposal, please open a new issue/RFC. You might also consider raising a PR to aws/aws-cdk directly or self-publishing to Construct Hub.

@mrgrain mrgrain closed this as completed Oct 27, 2023
@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale The RFC did not get any significant enough progress or tracking and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants