feat(region-info): throw ValidationError instead of untyped Errors

Author: mrgrain

packages/aws-cdk-lib/.eslintrc.js

@@ -25,7 +25,6 @@ const noThrowDefaultErrorNotYetSupported = [
   'aws-servicecatalog',
   'core',
   'custom-resources',
-  'region-info',
 ];
 baseConfig.overrides.push({
   files: [

packages/aws-cdk-lib/region-info/lib/aws-entities.ts

@@ -1,3 +1,5 @@
+import { UnscopedValidationError } from '../../core';
+
 /**
  * After this point, S3 website domains look like `s3-website.REGION.s3.amazonaws.com`
  *
@@ -88,7 +90,7 @@ export const AWS_REGIONS = AWS_REGIONS_AND_RULES
 export function before(region: string, ruleOrRegion: string | symbol) {
   const ruleIx = AWS_REGIONS_AND_RULES.indexOf(ruleOrRegion);
   if (ruleIx === -1) {
-    throw new Error(`Unknown rule: ${String(ruleOrRegion)}`);
+    throw new UnscopedValidationError(`Unknown rule: ${String(ruleOrRegion)}`);
   }
   const regionIx = AWS_REGIONS_AND_RULES.indexOf(region);
   return regionIx === -1 ? false : regionIx < ruleIx;
@@ -100,7 +102,7 @@ export function before(region: string, ruleOrRegion: string | symbol) {
 export function regionsBefore(ruleOrRegion: string | symbol): string[] {
   const ruleIx = AWS_REGIONS_AND_RULES.indexOf(ruleOrRegion);
   if (ruleIx === -1) {
-    throw new Error(`Unknown rule: ${String(ruleOrRegion)}`);
+    throw new UnscopedValidationError(`Unknown rule: ${String(ruleOrRegion)}`);
   }
   return AWS_REGIONS_AND_RULES.slice(0, ruleIx)
     .filter((entry) => typeof entry === 'string')

packages/aws-cdk-lib/region-info/lib/fact.ts

@@ -1,4 +1,5 @@
 import { AWS_REGIONS } from './aws-entities';
+import { UnscopedValidationError } from '../../core';
 
 /**
  * A database of regional information.
@@ -56,7 +57,7 @@ export class Fact {
     const foundFact = this.find(region, name);
 
     if (!foundFact) {
-      throw new Error(`No fact ${name} could be found for region: ${region} and name: ${name}.`);
+      throw new UnscopedValidationError(`No fact ${name} could be found for region: ${region} and name: ${name}.`);
     }
 
     return foundFact;
@@ -71,7 +72,7 @@ export class Fact {
   public static register(fact: IFact, allowReplacing = false): void {
     const regionFacts = this.database[fact.region] || (this.database[fact.region] = {});
     if (fact.name in regionFacts && regionFacts[fact.name] !== fact.value && !allowReplacing) {
-      throw new Error(`Region ${fact.region} already has a fact ${fact.name}, with value ${regionFacts[fact.name]}`);
+      throw new UnscopedValidationError(`Region ${fact.region} already has a fact ${fact.name}, with value ${regionFacts[fact.name]}`);
     }
     if (fact.value !== undefined) {
       regionFacts[fact.name] = fact.value;
@@ -88,15 +89,15 @@ export class Fact {
   public static unregister(region: string, name: string, value?: string): void {
     const regionFacts = this.database[region] || {};
     if (name in regionFacts && value && regionFacts[name] !== value) {
-      throw new Error(`Attempted to remove ${name} from ${region} with value ${value}, but the fact's value is ${regionFacts[name]}`);
+      throw new UnscopedValidationError(`Attempted to remove ${name} from ${region} with value ${value}, but the fact's value is ${regionFacts[name]}`);
     }
     delete regionFacts[name];
   }
 
   private static readonly database: { [region: string]: { [name: string]: string } } = {};
 
   private constructor() {
-    throw new Error('Use the static methods of Fact instead!');
+    throw new UnscopedValidationError('Use the static methods of Fact instead!');
   }
 }