Skip to content

Commit 4042938

Browse files
authored
Merge branch 'main' into 34768-aws_stepfunction_tasks-callawsservicecrossregions-lambda-doesnt-return-service-response-correctly
2 parents d2ee6e5 + bab7413 commit 4042938

File tree

124 files changed

+5453
-498
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+5453
-498
lines changed

.github/workflows/codecov-upload.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ jobs:
2424
uses: actions/download-artifact@v4
2525
with:
2626
name: coverage-artifacts
27-
path: ./coverage
27+
path: ./packages/aws-cdk-lib/core/coverage
2828
github-token: ${{ secrets.GITHUB_TOKEN }}
2929
repository: ${{ github.repository }}
3030
run-id: ${{ github.event.workflow_run.id }}
3131

3232
- name: Upload to Codecov
3333
uses: codecov/codecov-action@v5
3434
with:
35-
files: ./coverage/packages/aws-cdk-lib/coverage/cobertura-coverage.xml
35+
files: ./packages/aws-cdk-lib/core/coverage/cobertura-coverage.xml
3636
fail_ci_if_error: true
3737
flags: suite.unit
3838
use_oidc: true

.github/workflows/pr-build.yml

Lines changed: 39 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,26 @@
11
name: PR Build
22

33
on:
4+
workflow_dispatch: {}
5+
merge_group: {}
6+
push:
7+
branches:
8+
- main
9+
- v2-release
410
pull_request:
511
branches:
612
- main
713
- v2-release
814

15+
# For every PR, cancel any previous builds in progress
16+
# ... but for all other builds we keep them running
17+
concurrency:
18+
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.pull_request.number || github.run_id }}
19+
cancel-in-progress: true
20+
921
jobs:
1022
build:
11-
runs-on: aws-cdk_ubuntu-latest_16-core
23+
runs-on: aws-cdk_ubuntu-latest_32-core
1224

1325
env:
1426
PR_BUILD: true
@@ -18,24 +30,32 @@ jobs:
1830
uses: actions/checkout@v4
1931

2032
- name: Setup Node.js
21-
uses: actions/setup-node@v3
33+
uses: actions/setup-node@v4
2234
with:
2335
node-version: "18"
2436
cache: "yarn"
2537

2638
- name: Set up Docker
2739
uses: docker/setup-buildx-action@v3
2840

29-
# @TODO
30-
# - name: Start ECR proxy
31-
# run: /root/ecr-proxy/start.sh
41+
- name: Load Docker images
42+
id: docker-cache
43+
uses: actions/cache/restore@v4
44+
with:
45+
path: |
46+
~/.docker-images.tar
47+
key: docker-cache-${{ runner.os }}
48+
49+
- name: Restore Docker images
50+
if: ${{ steps.docker-cache.outputs.cache-hit }}
51+
run: docker image load --input ~/.docker-images.tar
3252

3353
- name: Cache build artifacts
34-
uses: actions/cache@v3
54+
uses: actions/cache@v4
3555
with:
3656
path: |
3757
~/.s3buildcache
38-
key: ${{ runner.os }}-${{ github.event.pull_request.base.ref }}-s3buildcache
58+
key: s3buildcache-${{ runner.os }}
3959

4060
- name: Configure system settings
4161
run: |
@@ -50,3 +70,15 @@ jobs:
5070

5171
- name: Check for uncommitted changes
5272
run: git diff-index --exit-code --ignore-space-at-eol --stat HEAD
73+
74+
- name: Export Docker images
75+
if: ${{ github.event_name == 'push' && github.ref_name == 'main' }}
76+
run: docker image save --output ~/.docker-images.tar $(docker image list --format '{{ if ne .Repository "<none>" }}{{ .Repository }}{{ if ne .Tag "<none>" }}:{{ .Tag }}{{ end }}{{ else }}{{ .ID }}{{ end }}')
77+
78+
- name: Cache Docker images
79+
if: ${{ github.event_name == 'push' && github.ref_name == 'main' }}
80+
uses: actions/cache/save@v4
81+
with:
82+
path: |
83+
~/.docker-images.tar
84+
key: docker-cache-${{ runner.os }}

.github/workflows/spec-update.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ name: AWS Service Spec Update
22

33
on:
44
schedule:
5-
# Every Monday at 13:37 UTC
6-
- cron: 37 13 * * 1
5+
# Every Monday at 10:15 UTC since dependency releases are on Fridays : https://github.com/cdklabs/awscdk-service-spec/releases?q=-spec&expanded=true
6+
- cron: 15 10 * * 1
77
workflow_dispatch: {}
88

99
jobs:

.mergify.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ queue_rules:
1616
- "#changes-requested-reviews-by=0"
1717
- status-success~=AWS CodeBuild us-east-1
1818
- status-success=validate-pr
19+
- status-success=build
1920
commit_message_template: |-
2021
{{ title }} (#{{ number }})
2122
{{ body }}
@@ -36,6 +37,7 @@ queue_rules:
3637
- "#changes-requested-reviews-by=0"
3738
- status-success~=AWS CodeBuild us-east-1
3839
- status-success=validate-pr
40+
- status-success=build
3941
commit_message_template: |-
4042
{{ title }} (#{{ number }})
4143
{{ body }}
@@ -55,6 +57,7 @@ queue_rules:
5557
- "#changes-requested-reviews-by=0"
5658
- status-success~=AWS CodeBuild us-east-1
5759
- status-success=validate-pr
60+
- status-success=build
5861
commit_message_template: |-
5962
{{ title }} (#{{ number }})
6063
{{ body }}
@@ -87,6 +90,7 @@ pull_request_rules:
8790
- "#changes-requested-reviews-by=0"
8891
- status-success~=AWS CodeBuild us-east-1
8992
- status-success=validate-pr
93+
- status-success=build
9094
- name: automatic priority merge
9195
actions:
9296
comment:
@@ -108,6 +112,7 @@ pull_request_rules:
108112
- "#changes-requested-reviews-by=0"
109113
- status-success~=AWS CodeBuild us-east-1
110114
- status-success=validate-pr
115+
- status-success=build
111116
- name: automatic merge (2+ approvers)
112117
actions:
113118
comment:
@@ -129,6 +134,7 @@ pull_request_rules:
129134
- "#changes-requested-reviews-by=0"
130135
- status-success~=AWS CodeBuild us-east-1
131136
- status-success=validate-pr
137+
- status-success=build
132138
- name: automatic merge (no-squash)
133139
actions:
134140
comment:
@@ -150,6 +156,7 @@ pull_request_rules:
150156
- "#changes-requested-reviews-by=0"
151157
- status-success~=AWS CodeBuild us-east-1
152158
- status-success=validate-pr
159+
- status-success=build
153160
- name: remove stale reviews
154161
actions:
155162
dismiss_reviews:
@@ -190,6 +197,7 @@ pull_request_rules:
190197
- "#changes-requested-reviews-by=0"
191198
- status-success~=AWS CodeBuild us-east-1
192199
- status-success=validate-pr
200+
- status-success=build
193201
priority_rules:
194202
- name: priority for queue `default-merge`
195203
conditions:

CONTRIBUTORS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Shout out to our top contributors!
99
- [jogold](https://github.com/jogold)
1010
- [iliapolo](https://github.com/iliapolo)
1111
- [corymhall](https://github.com/corymhall)
12-
- [shivlaks](https://github.com/shivlaks)
1312
- [mrgrain](https://github.com/mrgrain)
13+
- [shivlaks](https://github.com/shivlaks)
1414
- [otaviomacedo](https://github.com/otaviomacedo)
1515
- [mazyu36](https://github.com/mazyu36)
1616
- [pahud](https://github.com/pahud)
@@ -29,4 +29,4 @@ Shout out to our top contributors!
2929
- [colifran](https://github.com/colifran)
3030

3131

32-
_Last updated: Sun, 01 Jun 25 00:16:05 +0000_
32+
_Last updated: Tue, 01 Jul 25 00:15:11 +0000_

packages/@aws-cdk-testing/framework-integ/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"lint": "cdk-lint",
1010
"pkglint": "pkglint -f",
1111
"test": "cdk-test",
12-
"integ": "integ-runner --language javascript",
12+
"integ": "integ-runner --unstable=toolkit-lib-engine --language javascript",
1313
"package": "cdk-package",
1414
"build+test": "yarn build && yarn test",
1515
"build+extract": "yarn build",

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch/test/integ.alarm-and-dashboard.js.snapshot/aws-cdk-cloudwatch-alarms.assets.json

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch/test/integ.alarm-and-dashboard.js.snapshot/aws-cdk-cloudwatch-alarms.template.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"Type": "AWS::CloudWatch::Alarm",
88
"Properties": {
99
"ComparisonOperator": "GreaterThanOrEqualToThreshold",
10-
"EvaluationPeriods": 3,
1110
"DatapointsToAlarm": 2,
1211
"Dimensions": [
1312
{
@@ -20,6 +19,7 @@
2019
}
2120
}
2221
],
22+
"EvaluationPeriods": 3,
2323
"MetricName": "ApproximateNumberOfMessagesVisible",
2424
"Namespace": "AWS/SQS",
2525
"Period": 300,
@@ -94,7 +94,7 @@
9494
{
9595
"Ref": "AWS::Region"
9696
},
97-
"\",\"query\":\"SOURCE 'my-log-group' | fields @message\\n | filter @message like /Error/\"}},{\"type\":\"metric\",\"width\":6,\"height\":3,\"x\":0,\"y\":50,\"properties\":{\"view\":\"singleValue\",\"title\":\"Sent message size\",\"region\":\"",
97+
"\",\"accountId\":\"123456789012\",\"query\":\"SOURCE 'my-log-group' | fields @message\\n | filter @message like /Error/\"}},{\"type\":\"metric\",\"width\":6,\"height\":3,\"x\":0,\"y\":50,\"properties\":{\"view\":\"singleValue\",\"title\":\"Sent message size\",\"region\":\"",
9898
{
9999
"Ref": "AWS::Region"
100100
},

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch/test/integ.alarm-and-dashboard.js.snapshot/cdk.out

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch/test/integ.alarm-and-dashboard.js.snapshot/cdkcloudwatchalarmsintegtestDefaultTestDeployAssertD2D0B407.assets.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)