Skip to content

Commit 4cf8802

Browse files
author
Leon Michalski
committed
Fix constructs
1 parent 0d45114 commit 4cf8802

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import { CacheBehavior } from './private/cache-behavior';
1717
import { formatDistributionArn, grant } from './private/utils';
1818
import * as acm from '../../aws-certificatemanager';
1919
import * as cloudwatch from '../../aws-cloudwatch';
20+
import * as elasticloadbalancingv2 from '../../aws-elasticloadbalancingv2';
2021
import * as iam from '../../aws-iam';
2122
import * as lambda from '../../aws-lambda';
2223
import * as s3 from '../../aws-s3';
@@ -716,7 +717,9 @@ export class Distribution extends Resource implements IDistribution {
716717
const generatedId = Names.uniqueId(scope).slice(-ORIGIN_ID_MAX_LENGTH);
717718
const distributionId = this.distributionId;
718719
const originBindConfig = origin.bind(scope, { originId: generatedId, distributionId: Lazy.string({ produce: () => this.distributionId }) });
719-
const originId = originBindConfig.originProperty?.id ?? generatedId;
720+
const originId = (originBindConfig.originProperty?.id as elasticloadbalancingv2.ILoadBalancerRef)?.loadBalancerRef?.loadBalancerArn
721+
?? originBindConfig.originProperty?.id
722+
?? generatedId;
720723
const duplicateId = this.boundOrigins.find(boundOrigin => boundOrigin.originProperty?.id === originBindConfig.originProperty?.id);
721724
if (duplicateId) {
722725
throw new ValidationError(`Origin with id ${duplicateId.originProperty?.id} already exists. OriginIds must be unique within a distribution`, this);
@@ -741,7 +744,8 @@ export class Distribution extends Resource implements IDistribution {
741744
);
742745
return originGroupId;
743746
}
744-
return originBindConfig.originProperty?.id ?? originId;
747+
return (originBindConfig.originProperty?.id as elasticloadbalancingv2.ILoadBalancerRef)?.loadBalancerRef?.loadBalancerArn
748+
?? originBindConfig.originProperty?.id ?? originId;
745749
}
746750
}
747751

packages/aws-cdk-lib/aws-s3/lib/bucket.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2354,7 +2354,7 @@ export class Bucket extends BucketBase {
23542354

23552355
const objectLockConfiguration = this.parseObjectLockConfig(props);
23562356
const replicationConfiguration = this.renderReplicationConfiguration(props);
2357-
this.replicationRoleArn = replicationConfiguration?.role;
2357+
this.replicationRoleArn = (replicationConfiguration?.role as iam.IRoleRef)?.roleRef?.roleArn ?? replicationConfiguration?.role;
23582358
this.objectOwnership = props.objectOwnership;
23592359
this.transitionDefaultMinimumObjectSize = props.transitionDefaultMinimumObjectSize;
23602360
const resource = new CfnBucket(this, 'Resource', {

0 commit comments

Comments
 (0)