Skip to content

Commit 64408d9

Browse files
committed
minor fix
1 parent f217fe8 commit 64408d9

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

packages/@aws-cdk/aws-cloud9/lib/environment.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export class Ec2Environment extends cdk.Resource implements IEc2Environment {
136136
subnetId: this.vpc.selectSubnets(vpcSubnets).subnetIds[0],
137137
repositories: props.clonedRepositories ? props.clonedRepositories.map(r => ({
138138
repositoryUrl: r.repositoryUrl,
139-
pathComponent: r.clonePath,
139+
pathComponent: r.pathComponent,
140140
})) : undefined,
141141
});
142142
this.environmentId = c9env.ref;
@@ -152,13 +152,16 @@ export class Ec2Environment extends cdk.Resource implements IEc2Environment {
152152
export class CloneRepository {
153153
/**
154154
* import repository to cloud9 environment from AWS CodeCommit
155+
*
156+
* @param repository the codecommit repository to clone from
157+
* @param path the target path in cloud9 environment
155158
*/
156159
public static fromCodeCommit(repository: codecommit.IRepository, path: string): CloneRepository {
157160
return {
158161
repositoryUrl: repository.repositoryCloneUrlHttp,
159-
clonePath: path,
162+
pathComponent: path,
160163
};
161164
}
162165

163-
private constructor(public readonly repositoryUrl: string, public readonly clonePath: string) {}
166+
private constructor(public readonly repositoryUrl: string, public readonly pathComponent: string) {}
164167
}

packages/@aws-cdk/aws-cloud9/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
"resource-attribute:@aws-cdk/aws-cloud9.Ec2Environment.environmentEc2Arn",
9292
"resource-attribute:@aws-cdk/aws-cloud9.Ec2Environment.environmentEc2Name",
9393
"props-physical-name:@aws-cdk/aws-cloud9.Ec2EnvironmentProps",
94-
"docs-public-apis:@aws-cdk/aws-cloud9.CloneRepository.clonePath",
94+
"docs-public-apis:@aws-cdk/aws-cloud9.CloneRepository.pathComponent",
9595
"docs-public-apis:@aws-cdk/aws-cloud9.CloneRepository.repositoryUrl"
9696
]
9797
},

packages/@aws-cdk/aws-cloud9/test/cloud9.environment.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,15 +76,15 @@ test('can use CodeCommit repositories', () => {
7676
new cloud9.Ec2Environment(stack, 'C9Env', {
7777
vpc,
7878
clonedRepositories: [
79-
cloud9.CloneRepository.fromCodeCommit(repo, '/foo'),
79+
cloud9.CloneRepository.fromCodeCommit(repo, '/src'),
8080
],
8181
});
8282
// THEN
8383
expectCDK(stack).to(haveResourceLike('AWS::Cloud9::EnvironmentEC2', {
8484
InstanceType: 't2.micro',
8585
Repositories: [
8686
{
87-
PathComponent: '/foo',
87+
PathComponent: '/src',
8888
RepositoryUrl: {
8989
'Fn::Join': [
9090
'',

0 commit comments

Comments
 (0)