Skip to content

Commit 72dd7e9

Browse files
committed
Review comments
1 parent 18d83aa commit 72dd7e9

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/aws-cdk/lib/api/aws-auth/sdk-provider.ts

-1
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,6 @@ function parseHttpOptions(options: SdkHttpOptions) {
301301
debug('Using proxy server: %s', proxyAddress);
302302
// eslint-disable-next-line @typescript-eslint/no-require-imports
303303
const ProxyAgent: any = require('proxy-agent');
304-
// tslint:disable-next-line:no-console
305304
config.httpOptions.agent = new ProxyAgent(proxyAddress);
306305
}
307306
if (caBundlePath) {

packages/aws-cdk/test/api/sdk-provider.test.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,14 @@ describe('CLI compatible credentials loading', () => {
154154
// Messy mocking
155155
let called = false;
156156
jest.mock('proxy-agent', () => {
157+
// eslint-disable-next-line @typescript-eslint/no-require-imports
157158
class FakeAgent extends require('https').Agent {
158159
public addRequest(_: any, __: any) {
159-
// This error takes 6 seconds to be completely handled. It might be retries in the SDK
160-
// somewhere, or something about the Node event loop. I've spent an hour trying to figure
161-
// it out and I can't, and I gave up. We'll just have to live with this.
160+
// FIXME: this error takes 6 seconds to be completely handled. It
161+
// might be retries in the SDK somewhere, or something about the Node
162+
// event loop. I've spent an hour trying to figure it out and I can't,
163+
// and I gave up. We'll just have to live with this until someone gets
164+
// inspired.
162165
const error = new Error('ABORTED BY TEST');
163166
(error as any).code = 'RequestAbortedError';
164167
(error as any).retryable = false;

0 commit comments

Comments
 (0)