Skip to content

Commit 745922a

Browse files
authored
fix(lambda-python): allowPublicSubnet and filesystem not supported (#10022)
Fixes #10018. Fixes #10027. #9468 added a flag (`allowPublicSubnet`) to `FunctionProps`, but `PythonFunction` and `NodejsFunction` props derive from `FunctionOptions`. This renders these derived function constructs unable to bypass the public subnet check that occurs in the base `Function` construct. We can resolve this issue by moving `allowPublicSubnet` to `FunctionOptions`. I also moved `filesystem` up to `FunctionOptions` while I was here. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent ad7298f commit 745922a

File tree

4 files changed

+450
-16
lines changed

4 files changed

+450
-16
lines changed

packages/@aws-cdk/aws-lambda-python/package.json

+2
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,14 @@
6767
"dependencies": {
6868
"@aws-cdk/aws-lambda": "0.0.0",
6969
"@aws-cdk/core": "0.0.0",
70+
"@aws-cdk/aws-ec2": "0.0.0",
7071
"constructs": "^3.0.4"
7172
},
7273
"homepage": "https://github.com/aws/aws-cdk",
7374
"peerDependencies": {
7475
"@aws-cdk/aws-lambda": "0.0.0",
7576
"@aws-cdk/core": "0.0.0",
77+
"@aws-cdk/aws-ec2": "0.0.0",
7678
"constructs": "^3.0.4"
7779
},
7880
"engines": {

0 commit comments

Comments
 (0)