fix(diff): deepEqual may miss difference other than DependsOn (#10394)

Fixes #10322

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: kuwa0224

packages/@aws-cdk/cloudformation-diff/lib/diff/util.ts

@@ -44,7 +44,11 @@ export function deepEqual(lvalue: any, rvalue: any): boolean {
     if (keys.length !== Object.keys(rvalue).length) { return false; }
     for (const key of keys) {
       if (!rvalue.hasOwnProperty(key)) { return false; }
-      if (key === 'DependsOn') { return dependsOnEqual(lvalue[key], rvalue[key]); }
+      if (key === 'DependsOn') {
+        if (!dependsOnEqual(lvalue[key], rvalue[key])) { return false; };
+        // check differences other than `DependsOn`
+        continue;
+      }
       if (!deepEqual(lvalue[key], rvalue[key])) { return false; }
     }
     return true;

packages/@aws-cdk/cloudformation-diff/test/diff-template.test.ts

@@ -520,3 +520,36 @@ test('boolean properties are considered equal with their stringified counterpart
   // THEN
   expect(differences.differenceCount).toBe(0);
 });
+
+test('when a property changes including equivalent DependsOn', () => {
+  // GIVEN
+  const bucketName = 'ShineyBucketName';
+  const currentTemplate = {
+    Resources: {
+      BucketResource: {
+        Type: 'AWS::S3::Bucket',
+        DependsOn: ['SomeResource'],
+        BucketName: bucketName,
+      },
+    },
+  };
+
+  // WHEN
+  const newBucketName = `${bucketName}-v2`;
+  const newTemplate = {
+    Resources: {
+      BucketResource: {
+        Type: 'AWS::S3::Bucket',
+        DependsOn: ['SomeResource'],
+        BucketName: newBucketName,
+      },
+    },
+  };
+
+  // THEN
+  let differences = diffTemplate(currentTemplate, newTemplate);
+  expect(differences.resources.differenceCount).toBe(1);
+
+  differences = diffTemplate(newTemplate, currentTemplate);
+  expect(differences.resources.differenceCount).toBe(1);
+});