Commit a374b6b
authored
feat(events-targets): support Amazon Data Firehose target using Firehose's
### Issue # (if applicable)
Related to #33757 and #33758
### Reason for this change
The module has the `KinesisFirehoseStreamV2` target class for Firehose delivery stream.
But it has following issues:
- Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class should not be called Kinesis. Also, KinesisFirehoseStream is confusable with Kinesis Data Stream.
- The constructor receives internally defined `IDeliveryStream` which is a subset of `aws_kinesisfirehose.IDeliveryStream` without inheritance. This may cause jsii type compatibility problem.
### Description of changes
- Added a new `FirehoseDeliveryStream` target class derived from `KinesisFirehoseStreamV2` but receives `aws_kinesisfirehose.IDeliveryStream` instead.
- Deprecated `KinesisFirehoseStreamV2` and internal `IDeliveryStream`.
- Added missing unit tests for `FirehoseDeliveryStream`
- Updated the integ test to use `FirehoseDeliveryStream` and assertions.
- Added an missing README entry refers Amazon Data Firehose.
### Describe any new or updated permissions being added
N/A - `FirehoseDeliveryStream` adds same permissions as `KinesisFirehoseStreamV2`
### Description of how you validated changes
Unit tests and integ test.
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*IDeliveryStream (#33798)1 parent ff83cfd commit a374b6b
File tree
23 files changed
+33059
-629
lines changed- packages
- @aws-cdk-testing/framework-integ/test/aws-events-targets/test
- firehose
- integ.firehose-delivery-stream.js.snapshot
- asset.44e9c4d7a5d3fd2d677e1a7e416b2b56f6b0104bd5eff9cac5557b4c65a9dc61
- asset.c11608a15785084ea1afe65826e575ee316add10c8b1bb373e93297e26aec564.bundle
- kinesis-firehose
- integ.kinesis-firehose-stream.js.snapshot
- aws-cdk-lib/aws-events-targets
- lib
- test
- firehose
- kinesis-firehose
23 files changed
+33059
-629
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments