Skip to content

Commit a67c3f5

Browse files
authored
chore: retain replica table (under feature flag) (#33970)
Follow up to this PR to add feature flag #33953
1 parent 2a8a8a3 commit a67c3f5

File tree

16 files changed

+171
-33
lines changed

16 files changed

+171
-33
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.js.snapshot/aws-cdk-dynamodb-global-replicas-provisioned.assets.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.js.snapshot/aws-cdk-dynamodb-global-replicas-provisioned.template.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,7 @@
166166
"TableName": {
167167
"Ref": "TableCD117FA1"
168168
},
169-
"Region": "us-east-2",
170-
"SkipReplicaDeletion": false
169+
"Region": "us-east-2"
171170
},
172171
"DependsOn": [
173172
"TableSourceTableAttachedManagedPolicyawscdkdynamodbglobalreplicasprovisionedawscdkawsdynamodbReplicaProviderIsCompleteHandlerServiceRoleBE2B1C1A5DC546D2",
@@ -191,8 +190,7 @@
191190
"TableName": {
192191
"Ref": "TableCD117FA1"
193192
},
194-
"Region": "eu-west-3",
195-
"SkipReplicaDeletion": false
193+
"Region": "eu-west-3"
196194
},
197195
"DependsOn": [
198196
"TableSourceTableAttachedManagedPolicyawscdkdynamodbglobalreplicasprovisionedawscdkawsdynamodbReplicaProviderIsCompleteHandlerServiceRoleBE2B1C1A5DC546D2",

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.js.snapshot/manifest.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global-replicas-provisioned.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import * as dynamodb from 'aws-cdk-lib/aws-dynamodb';
66
const app = new cdk.App({
77
postCliContext: {
88
'@aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy': false,
9+
'@aws-cdk/aws-dynamodb:retainTableReplica': false,
910
},
1011
});
1112
const stack = new cdk.Stack(app, 'aws-cdk-dynamodb-global-replicas-provisioned');

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global.js.snapshot/cdk-dynamodb-global-20191121.assets.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global.js.snapshot/cdk-dynamodb-global-20191121.template.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,7 @@
195195
"TableName": {
196196
"Ref": "TableCD117FA1"
197197
},
198-
"Region": "eu-west-2",
199-
"SkipReplicaDeletion": false
198+
"Region": "eu-west-2"
200199
},
201200
"DependsOn": [
202201
"TableSourceTableAttachedManagedPolicycdkdynamodbglobal20191121awscdkawsdynamodbReplicaProviderIsCompleteHandlerServiceRole3971612857304880",
@@ -217,8 +216,7 @@
217216
"TableName": {
218217
"Ref": "TableCD117FA1"
219218
},
220-
"Region": "eu-central-1",
221-
"SkipReplicaDeletion": false
219+
"Region": "eu-central-1"
222220
},
223221
"DependsOn": [
224222
"TableReplicaeuwest290D3CD3A",

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global.js.snapshot/manifest.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.global.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class TestStack extends Stack {
3434
const app = new App({
3535
postCliContext: {
3636
'@aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy': false,
37+
'@aws-cdk/aws-dynamodb:retainTableReplica': false,
3738
},
3839
});
3940
const stack = new TestStack(app, 'cdk-dynamodb-global-20191121', { env: { region: 'eu-west-1' } });

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.table-skip-replica-deletion.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ class TestStack extends Stack {
2424
}
2525
}
2626

27-
const app = new App();
27+
const app = new App({
28+
postCliContext: {
29+
'@aws-cdk/aws-dynamodb:retainTableReplica': true,
30+
},
31+
});
2832
const stack = new TestStack(app, 'cdk-dynamodb-skip-replica-deletion');
2933

3034
new IntegTest(

packages/@aws-cdk-testing/framework-integ/test/custom-resources/test/custom-resource-config/integ.custom-resource-config-lambda-node-runtime.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@ import * as dynamodb from 'aws-cdk-lib/aws-dynamodb';
44
import * as lambda from 'aws-cdk-lib/aws-lambda';
55
import { CustomResourceConfig } from 'aws-cdk-lib/custom-resources';
66

7-
const app = new cdk.App();
7+
const app = new cdk.App({
8+
postCliContext: {
9+
'@aws-cdk/aws-dynamodb:retainTableReplica': true,
10+
},
11+
});
812
const stack = new cdk.Stack(app, 'MyStack');
913

1014
new dynamodb.Table(stack, 'Table', {

0 commit comments

Comments
 (0)