Skip to content

Commit a8fe799

Browse files
authored
Merge branch 'master' into corymhall/fix-codepipeline-actions-integ
2 parents 6440166 + 89d471d commit a8fe799

File tree

442 files changed

+3987
-6520
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

442 files changed

+3987
-6520
lines changed

.github/ISSUE_TEMPLATE/bug.yml .github/ISSUE_TEMPLATE/bug-report.yml

+39-26
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,64 @@
1-
name: Bug Report
1+
---
2+
name: "🐛 Bug Report"
23
description: Report a bug
3-
title: "(module name): short issue description"
4+
title: "(module name): (short issue description)"
45
labels: [bug, needs-triage]
6+
assignees: []
57
body:
68
- type: textarea
7-
id: problem
9+
id: description
810
attributes:
9-
label: What is the problem?
11+
label: Describe the bug
12+
description: What is the problem? A clear and concise description of the bug.
1013
validations:
1114
required: true
12-
1315
- type: textarea
14-
id: reproduction
16+
id: expected
1517
attributes:
16-
label: Reproduction Steps
18+
label: Expected Behavior
1719
description: |
18-
Minimal amount of code that causes the bug (if possible) or a reference.
19-
20-
The code sample should be an SSCCE. See http://sscce.org/ for details.
21-
In short, provide a code sample that we can copy/paste, run and reproduce.
20+
What did you expect to happen?
2221
validations:
2322
required: true
24-
2523
- type: textarea
26-
id: expected
24+
id: current
2725
attributes:
28-
label: What did you expect to happen?
26+
label: Current Behavior
2927
description: |
30-
What were you trying to achieve by performing the steps above?
28+
What actually happened?
29+
30+
Please include full errors, uncaught exceptions, stack traces, and relevant logs.
31+
If service responses are relevant, please include wire logs.
3132
validations:
3233
required: true
33-
3434
- type: textarea
35-
id: actual
35+
id: reproduction
3636
attributes:
37-
label: What actually happened?
37+
label: Reproduction Steps
3838
description: |
39-
What is the unexpected behavior you were seeing? If you got an error, paste it here.
39+
Provide a self-contained, concise snippet of code that can be used to reproduce the issue.
40+
For more complex issues provide a repo with the smallest sample that reproduces the bug.
41+
42+
Avoid including business logic or unrelated code, it makes diagnosis more difficult.
43+
The code sample should be an SSCCE. See http://sscce.org/ for details. In short, please provide a code sample that we can copy/paste, run and reproduce.
4044
validations:
4145
required: true
46+
- type: textarea
47+
id: solution
48+
attributes:
49+
label: Possible Solution
50+
description: |
51+
Suggest a fix/reason for the bug
52+
validations:
53+
required: false
54+
- type: textarea
55+
id: context
56+
attributes:
57+
label: Additional Information/Context
58+
description: |
59+
Anything else that might be relevant for troubleshooting this bug. Providing context helps us come up with a solution that is most useful in the real world.
60+
validations:
61+
required: false
4262

4363
- type: input
4464
id: cdk-version
@@ -99,10 +119,3 @@ body:
99119
e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, slack, etc
100120
validations:
101121
required: false
102-
103-
- type: markdown
104-
attributes:
105-
value: |
106-
---
107-
108-
This is :bug: Bug Report

.github/ISSUE_TEMPLATE/config.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
---
12
blank_issues_enabled: false
23
contact_links:
3-
- name: Stackoverflow
4-
url: https://stackoverflow.com/questions/tagged/aws-cdk
5-
about: Please ask and answer questions here.
4+
- name: 💬 General Question
5+
url: https://github.com/aws/aws-cdk/discussions/categories/q-a
6+
about: Please ask and answer questions as a discussion thread

.github/ISSUE_TEMPLATE/doc.yml

-32
This file was deleted.
+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
---
2+
name: "📕 Documentation Issue"
3+
description: Report an issue in the API Reference documentation or Developer Guide
4+
title: "(short issue description)"
5+
labels: [documentation, needs-triage]
6+
assignees: []
7+
body:
8+
- type: textarea
9+
id: description
10+
attributes:
11+
label: Describe the issue
12+
description: A clear and concise description of the issue.
13+
validations:
14+
required: true
15+
16+
- type: textarea
17+
id: links
18+
attributes:
19+
label: Links
20+
description: |
21+
Include links to affected documentation page(s).
22+
validations:
23+
required: true
+26-23
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,59 @@
1-
name: Feature Request
2-
description: Request a new feature
3-
title: "(module name): short issue description"
1+
---
2+
name: 🚀 Feature Request
3+
description: Suggest an idea for this project
4+
title: "(short issue description)"
45
labels: [feature-request, needs-triage]
6+
assignees: []
57
body:
68
- type: textarea
79
id: description
810
attributes:
9-
label: Description
10-
description: Short description of the feature you are proposing.
11+
label: Describe the feature
12+
description: A clear and concise description of the feature you are proposing.
1113
validations:
1214
required: true
13-
1415
- type: textarea
1516
id: use-case
1617
attributes:
1718
label: Use Case
1819
description: |
19-
Why do you need this feature?
20+
Why do you need this feature? For example: "I'm always frustrated when..."
2021
validations:
21-
required: true
22-
22+
required: true
2323
- type: textarea
2424
id: solution
2525
attributes:
2626
label: Proposed Solution
2727
description: |
28-
Please include prototype/workaround/sketch/reference implementation.
28+
Suggest how to implement the addition or change. Please include prototype/workaround/sketch/reference implementation.
2929
validations:
30-
required: true
31-
30+
required: false
3231
- type: textarea
3332
id: other
3433
attributes:
35-
label: Other information
34+
label: Other Information
3635
description: |
37-
e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, slack, etc
36+
Any alternative solutions or features you considered, a more detailed explanation, stack traces, related issues, links for context, etc.
3837
validations:
3938
required: false
40-
4139
- type: checkboxes
42-
id: acknowledgments
40+
id: ack
4341
attributes:
44-
label: Acknowledge
42+
label: Acknowledgements
4543
options:
4644
- label: I may be able to implement this feature request
4745
required: false
4846
- label: This feature might incur a breaking change
4947
required: false
50-
51-
- type: markdown
48+
- type: input
49+
id: sdk-version
5250
attributes:
53-
value: |
54-
---
55-
56-
This is a :rocket: Feature Request
51+
label: CDK version used
52+
validations:
53+
required: true
54+
- type: input
55+
id: environment
56+
attributes:
57+
label: Environment details (OS name and version, etc.)
58+
validations:
59+
required: true

.github/ISSUE_TEMPLATE/general-issue.yml

-87
This file was deleted.

.github/workflows/issue-label-assign.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ on:
33
issues:
44
types: [opened, edited]
55
pull_request:
6-
types: [opened, edited]
6+
types: [opened]
77
pull_request_target:
8-
types: [opened, edited]
8+
types: [opened]
99

1010
jobs:
1111
issue-triage-manager:
@@ -39,7 +39,7 @@ jobs:
3939
included-labels: "[guidance]"
4040
default-area: ${{ env.OSDS_DEVS }}
4141
parameters: >
42-
[{"area":"guidance","keywords":["guidance"]}]
42+
[{"area":"guidance","keywords":["guidancekeyword"]}]
4343
pr-triage-manager:
4444
permissions:
4545
issues: write
@@ -51,9 +51,11 @@ jobs:
5151
github-token: "${{ secrets.GITHUB_TOKEN }}"
5252
target: "pull-requests"
5353
area-is-keyword: true
54-
excluded-labels: "[contribution/core]"
55-
parameters: ${{ env.AREA_PARAMS }}
56-
affixes: ${{ env.AREA_AFFIXES }}
54+
default-area: >
55+
{"reviewers":{"teamReviewers":["aws-cdk-owners"]}}
56+
parameters: >
57+
[{"area":"pullrequests","keywords":["pullrequestkeyword"]}]
58+
5759
5860
env:
5961
OSDS_DEVS: >

0 commit comments

Comments
 (0)