Skip to content

Commit

Permalink
fix(s3-deployment): lambda "src" not included in published module (#4430
Browse files Browse the repository at this point in the history
)

As of v1.12.0, we customized the calculation of the custom resource hash
to use the contents of the "src" directory instead of the bundle.zip itself
in order to keep it deterministic (the bundle is created during build by
pulling in external dependencies and includes compiled python files which
caused it have a different hash in each build).

However, the "lambda/src" directory was explicitly excluded from the
module's tarball (in .npmignore), so when this module was used in production,
it could not find "lambda/src" in order to calculate the hash.

This fixes #4404 by removing `lambda/src` from `.npmignore`.
  • Loading branch information
Elad Ben-Israel authored and mergify[bot] committed Oct 9, 2019
1 parent 11d18e0 commit d16080a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-s3-deployment/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dist
# Include .jsii
!.jsii

lambda/src
lambda/test
lambda/*.sh
*.snk
Expand Down

0 comments on commit d16080a

Please sign in to comment.