Skip to content

Commit df334cd

Browse files
committed
improve code
1 parent 8af9fc3 commit df334cd

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

packages/@aws-cdk/aws-elasticloadbalancingv2/lib/nlb/network-load-balancer.ts

+6-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as cloudwatch from '@aws-cdk/aws-cloudwatch';
22
import * as ec2 from '@aws-cdk/aws-ec2';
33
import { PolicyStatement, ServicePrincipal } from '@aws-cdk/aws-iam';
44
import { IBucket } from '@aws-cdk/aws-s3';
5-
import { Construct, Resource, Stack } from '@aws-cdk/core';
5+
import { Construct, Resource } from '@aws-cdk/core';
66
import { BaseLoadBalancer, BaseLoadBalancerProps, ILoadBalancerV2 } from '../shared/base-load-balancer';
77
import { BaseNetworkListenerProps, NetworkListener } from './network-listener';
88

@@ -115,12 +115,14 @@ export class NetworkLoadBalancer extends BaseLoadBalancer implements INetworkLoa
115115
public logAccessLogs(bucket: IBucket, prefix?: string) {
116116
super.logAccessLogs(bucket, prefix);
117117

118+
const logsDeliveryServicePrincipal = new ServicePrincipal('delivery.logs.amazonaws.com');
119+
118120
bucket.addToResourcePolicy(
119121
new PolicyStatement({
120122
actions: ['s3:PutObject'],
121-
principals: [new ServicePrincipal('delivery.logs.amazonaws.com')],
123+
principals: [logsDeliveryServicePrincipal],
122124
resources: [
123-
bucket.arnForObjects(`${prefix ? prefix + '/' : ''}AWSLogs/${Stack.of(this).account}/*`),
125+
bucket.arnForObjects(`${prefix ? prefix + '/' : ''}AWSLogs/${this.stack.account}/*`),
124126
],
125127
conditions: {
126128
StringEquals: { 's3:x-amz-acl': 'bucket-owner-full-control' },
@@ -130,7 +132,7 @@ export class NetworkLoadBalancer extends BaseLoadBalancer implements INetworkLoa
130132
bucket.addToResourcePolicy(
131133
new PolicyStatement({
132134
actions: ['s3:GetBucketAcl'],
133-
principals: [new ServicePrincipal('delivery.logs.amazonaws.com')],
135+
principals: [logsDeliveryServicePrincipal],
134136
resources: [bucket.bucketArn],
135137
}),
136138
);

0 commit comments

Comments
 (0)