Skip to content

Commit f4b26af

Browse files
fix(secretsmanager): secret transformation (#35202)
* Use new transform to update from deprecated python 3.9 lambda runtime ### Issue # (if applicable) Closes #34168 ### Reason for this change * Lambda runtime python 3.9 is marked for deprecation and therefore should be updated ### Description of changes * Use new serverless transformation ### Describe any new or updated permissions being added none ### Description of how you validated changes existing unit tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 7d70bf4 commit f4b26af

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.serverless-cluster-secret-rotation-custom-names.js.snapshot/aws-cdk-rds-integ-secret-rotation.template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"Transform": "AWS::SecretsManager-2020-07-23",
2+
"Transform": "AWS::SecretsManager-2024-09-16",
33
"Resources": {
44
"DbSecurity381C2C15": {
55
"Type": "AWS::KMS::Key",

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.serverless-cluster-secret-rotation.js.snapshot/aws-cdk-rds-integ-secret-rotation.template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"Transform": "AWS::SecretsManager-2020-07-23",
2+
"Transform": "AWS::SecretsManager-2024-09-16",
33
"Resources": {
44
"DbSecurity381C2C15": {
55
"Type": "AWS::KMS::Key",

packages/@aws-cdk-testing/framework-integ/test/aws-secretsmanager/test/integ.hosted-rotation.js.snapshot/cdk-integ-secret-hosted-rotation.template.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"Transform": [
3-
"AWS::SecretsManager-2020-07-23"
3+
"AWS::SecretsManager-2024-09-16"
44
],
55
"Resources": {
66
"SecretA720EF05": {

packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ export class HostedRotation implements ec2.IConnectable {
314314
*/
315315
public bind(secret: ISecret, scope: Construct): CfnRotationSchedule.HostedRotationLambdaProperty {
316316
// https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-secretsmanager-rotationschedule-hostedrotationlambda.html
317-
Stack.of(scope).addTransform('AWS::SecretsManager-2020-07-23');
317+
Stack.of(scope).addTransform('AWS::SecretsManager-2024-09-16');
318318

319319
if (!this.props.vpc && this.props.securityGroups) {
320320
throw new ValidationError('`vpc` must be specified when specifying `securityGroups`.', secret);

packages/aws-cdk-lib/aws-secretsmanager/test/rotation-schedule.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ describe('default tests', () => {
159159
});
160160

161161
expect(app.synth().getStackByName(stack.stackName).template).toEqual(expect.objectContaining({
162-
Transform: 'AWS::SecretsManager-2020-07-23',
162+
Transform: 'AWS::SecretsManager-2024-09-16',
163163
}));
164164

165165
Template.fromStack(stack).hasResourceProperties('AWS::SecretsManager::ResourcePolicy', {

0 commit comments

Comments
 (0)