Commit fe0ecb4
authored
chore(custom-resources): update and fix integ test (#19499)
Fixes #19450.
The issue is the public read permissions. Even though the s3 bucket is configured to allow these permissions, public access can be blocked at the [account](https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-control-block-public-access.html) level. This makes the custom resource unable to put a public object into the bucket despite correct permissions, causing deployment failure.
Since this is a bad experience and the object is unnecessarily public, I have removed that setting.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*1 parent 28d87bb commit fe0ecb4
File tree
3 files changed
+3
-5
lines changed- packages/@aws-cdk/custom-resources/test/provider-framework
- integration-test-fixtures
3 files changed
+3
-5
lines changedLines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
131 | 130 | | |
132 | 131 | | |
133 | 132 | | |
134 | | - | |
| 133 | + | |
135 | 134 | | |
136 | 135 | | |
137 | 136 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
0 commit comments