feat(route53-patterns): support IPv6 in HttpsRedirect #10203
Conversation
Currently, the HttpsRedirect construct provisions an IPv6-enabled CloudFront distribution, but only wires up an A (IPv4) alias record to the distribution in Route 53. Add an AAAA (IPv6) alias record to directly support this traffic. See: https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-cloudfront-distribution.html
There was a problem hiding this comment.
@corpulentcoffee - thanks for the contribution!! it was certainly a miss on our part to enable this by default. Since this is a patterns library, I think this is a sensible default.
I'm not sure if there's any use case where only IPv4 is needed explicitly, but if that turns out to be the case, we might need to expose a switch that allows users to opt-out. For now, I'd rather not introduce that capability though.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Currently, the HttpsRedirect construct provisions an IPv6-enabled
CloudFront distribution, but only wires up an A (IPv4) alias record to
the distribution in Route 53.
Add an AAAA (IPv6) alias record to directly support this traffic.
See:
https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/routing-to-cloudfront-distribution.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license