fix(core): DefaultSynthesizer breaks this.node.setContext() on Stack #10246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `DefaultSynthesizer` recently started adding constructs into
the Stack at construction time, that broke `this.node.setContext()`
which requires that no children have been added to a construct yet
when its context is being modified.
To fix this, add the constructs just-in-time just before the stack
is being synthesized.
In order to give the `DefaultStackSynthesizer` a chance to modify
the stack's construct tree before its template is being written out,
the Synthesizer is now in full control of the order in which things
happen.
Change the call tree from:
```
synthesizeTree
- stack._synthesizeTemplate
- (write template)
- this.synthesizer.synthesizeStackArtifacts
- (register artifacts)
```
To:
```
synthesizeTree
- stack.synthesizer.synthesize
- stack._synthesizeTemplate
- (write template)
- (register artifacts)
```
All APIs involved in this call tree are either `@experimental` or
`@internal`.
BREAKING CHANGE: custom implementations of `IStackSynthesizer`
must now implement `synthesize()` instead of
`synthesizeStackArtifacts()`.
eladb
reviewed
Sep 8, 2020
| assertBound(this.stack); | ||
|
|
||
| this.stack._synthesizeTemplate(session); |
There was a problem hiding this comment.
Do we really need to relay back to Stack? Maybe we can just move all the code into here?
There was a problem hiding this comment.
_synthesizeTemplate is accessing all private members. This feels cleaner than exposing those.
eladb
approved these changes
Sep 8, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
DefaultSynthesizerrecently started adding constructs intothe Stack at construction time, that broke
this.node.setContext()which requires that no children have been added to a construct yet
when its context is being modified.
To fix this, add the constructs just-in-time just before the stack
is being synthesized.
In order to give the
DefaultStackSynthesizera chance to modifythe stack's construct tree before its template is being written out,
the Synthesizer is now in full control of the order in which things
happen.
Change the call tree from:
To:
All APIs involved in this call tree are either
@experimentalor@internal.BREAKING CHANGE: custom implementations of
IStackSynthesizermust now implement
synthesize()instead ofsynthesizeStackArtifacts().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license