Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecr] Amazon ECR with KMS support #10379

Closed
1 of 2 tasks
pahud opened this issue Sep 15, 2020 · 5 comments
Closed
1 of 2 tasks

[ecr] Amazon ECR with KMS support #10379

pahud opened this issue Sep 15, 2020 · 5 comments
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2

Comments

@pahud
Copy link
Contributor

pahud commented Sep 15, 2020 •
edited
Loading

https://aws.amazon.com/tw/about-aws/whats-new/2020/07/ecr-supports-encryption-images-aws-kms-keys/

Use Case

ECR repo with KMS encryption

Proposed Solution

As it's not yet supported in cfn, we probably can use custom-resource to create a construct property for it.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 15, 2020
@github-actions github-actions bot added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Sep 15, 2020
@MrArnoldPalmer MrArnoldPalmer added effort/large Large work item – several weeks of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 26, 2020
@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 21, 2021
@lony
Copy link

lony commented Aug 9, 2021

It's now supported by CloudFormation and would be nice if added as well. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#cfn-ecr-repository-encryptionconfiguration

@udondan
Copy link
Contributor

udondan commented Feb 4, 2022

This is available now since 1.143.0 via #16966

@udondan
Copy link
Contributor

udondan commented Nov 7, 2023

Ping @pahud ... uhm... @rix0rrr maybe? This can be closed.

@pahud
Copy link
Contributor Author

pahud commented Jun 4, 2024

@udondan Thank you!

@pahud pahud closed this as completed Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pahud @lony @udondan @MrArnoldPalmer