Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing] npm run build: Checking javac version... Found javac version javac 15. Install javac >= 1.8.0 #10416

Closed
Wenzil opened this issue Sep 17, 2020 · 2 comments
Assignees
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@Wenzil
Copy link
Contributor

Wenzil commented Sep 17, 2020

Building aws-cdk itself fails at the javac version check step.

Reproduction Steps

git clone git@github.com:aws/aws-cdk.git
cd aws-cdk
npm run build

What did you expect to happen?

I expected the project to build successfully.

What actually happened?

The build fails with the following logs:

npm run build

> aws-cdk@0.0.0 build /Users/<omitted>/repos/aws/aws-cdk
> ./build.sh

=============================================================================================
installing...
yarn install v1.22.5
[1/4] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 4.59s.
git: 'secrets' is not a git command. See 'git --help'.
git-secrets scan ok
Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if javac is installed... Ok
Checking javac version... Found javac version javac 15. Install javac >= 1.8.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! aws-cdk@0.0.0 build: `./build.sh`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the aws-cdk@0.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/<omitted>/.npm/_logs/2020-09-17T16_50_26_331Z-debug.log

Environment

  • CLI Version : 1.63.0
  • Framework Version: 1.63.0
  • Node.js Version: v14.11.0
  • OS : macOS Catalina
  • Language (Version): 3.9.7

Other

I manually installed OpenJDK 15 on macOS Catalina by downloading the tar.gz archive from the official download page and copied its contents to /Library/Java/JavaVirtualMachines/ as described in this StackOverflow answer.

javac -version output:

javac 15

This is 🐛 Bug Report

@Wenzil Wenzil added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 17, 2020
@ericzbeard
Copy link
Contributor

Fixed by #11087

@github-actions
Copy link

github-actions bot commented Nov 5, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants