fix(core): Stacks from 3rd-party libraries do not synthesize correctly #10690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though this is arguably somewhat of an antipattern and user error: - You should not be vending `Stack`s from libraries. - All libraries should be using a single version of the CDK so that NPM can dedupe it (or use `peerDependencies` to avoid this altogether) This is still a sharp edge that we can blunt a little by not using the `instanceof` language feature. No test because it needs a second copy of the CDK to expose it. Fixes #10671.
eladb
approved these changes
Oct 5, 2020
rix0rrr
added
the
pr-linter/exempt-test
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this is arguably somewhat of an antipattern and user error:
Stacks from libraries.NPM can dedupe it (or use
peerDependenciesto avoid this altogether)This is still a sharp edge that we can blunt a little by not using
the
instanceoflanguage feature.No test because it needs a second copy of the CDK to expose it.
Fixes #10671.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license