Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): 'stack already contains Metadata resource' warning #10695

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 5, 2020

This warning was added to detect an inability to add the metadata
resource in the CLI, before the framework started emitting the metadata
resource by default. Now it's expected, and the warning doesn't
make any sense anymore.

Fixes #10625.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This warning was added to detect an inability to add the metadata
resource in the CLI, before the framework started emitting the metadata
resource by default. Now it's expected, and the warning doesn't
make any sense anymore.

Fixes #10625.
@rix0rrr rix0rrr requested a review from a team October 5, 2020 09:22
@rix0rrr rix0rrr self-assigned this Oct 5, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 5, 2020
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Oct 5, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8dbfca5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e0b5508 into master Oct 5, 2020
@mergify mergify bot deleted the huijbers/metadata-warning branch October 5, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] CDKMetada resource warning
4 participants