feat(ecs): secret JSON field for Fargate tasks #11348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fargate tasks running on platform version 1.4 can now reference a specific JSON field of a secret stored in Secrets Manager. Remove the error `ContainerDefinition` and add a check on the platform version in `FargateService`. See https://aws.amazon.com/about-aws/whats-new/2020/11/aws-fargate-for-amazon-ecs-launches-features-focused-on-configuration-and-metrics/ Closes aws#11341
|
|
2 tasks
SoManyHs
reviewed
Nov 10, 2020
SoManyHs
previously approved these changes
Nov 10, 2020
mergify
bot
dismissed
SoManyHs’s stale review
Pull request has been modified.
|
@SoManyHs Can you reapprove? You merged from master after reviewing, this dismisses the review. |
|
@SoManyHs ping |
Closed
2 tasks
|
@SoManyHs an approval would be much appreciated, so we can use the feature within our deployments :-) |
|
@marcotesch you can use the following workaround in the meantime #11341 (comment) |
Ah, didn't see that. Sorry about the delay! |
SoManyHs
approved these changes
Nov 13, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fargate tasks running on platform version 1.4 can now reference a
specific JSON field of a secret stored in Secrets Manager.
Remove the error in
ContainerDefinitionand add a check on theplatform version in
FargateService.See https://aws.amazon.com/about-aws/whats-new/2020/11/aws-fargate-for-amazon-ecs-launches-features-focused-on-configuration-and-metrics/
See aws/containers-roadmap#385 (comment)
Closes #11341
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license