Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): rds data source configured with cluster arn #12255

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

BryanPan342
Copy link
Contributor

Lazily add a formatted cluster arn to the RdsHttpEndpointConfig. Before we were just adding the cluster id, but the docs call for the Cluster Arn instead.

Fixes: #11536


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 29, 2020

@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Dec 29, 2020
@BryanPan342
Copy link
Contributor Author

@MrArnoldPalmer Not sure what the issue is with the check, but if you can point me in the right direction I can fix it

@MrArnoldPalmer
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Command update: success

Branch has been successfully updated

@MrArnoldPalmer
Copy link
Contributor

@BryanPan342 we had an issue with codebuild log comments not being published. I refreshed to trigger a rebuild as this should be fixed.

Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 TY @BryanPan342 !!

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cc44f42
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d0305f3 into aws:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-appsync] RdsDataSource fails to include clusterArn
3 participants