Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-deployment): stop using deprecated API's that will cause breakage post 01/31/21 #12491

Merged
merged 9 commits into from
Jan 14, 2021

Conversation

iliapolo
Copy link
Contributor

We currently use deprecated API's from the Lambda runtime that will be removed on January 30 2021.

This PR replaces those API usages with direct urllib usage, which is a built-in module available in any python installation.

Fixes #12219


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 13, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 13, 2021
@iliapolo iliapolo requested a review from a team January 13, 2021 19:14
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@NetaNir
Copy link
Contributor

NetaNir commented Jan 14, 2021

Updated snapshot

Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Maybe change the title to something a bit better. Something like 'stop using deprecated botocore APIs'. The title as-is will make little sense to customers reading the changelog.

@iliapolo iliapolo changed the title fix(s3-deployment): module will break after 01/30/21 fix(s3-deployment): stop using deprecated API's that will cause breakage post 01/31/21 Jan 14, 2021
@@ -711,21 +711,21 @@
"Code": {
Copy link
Contributor Author

@iliapolo iliapolo Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This integ test uses BucketDeployment, hence the asset changes.

const envFileDeployment = new s3deployment.BucketDeployment(stack, 'EnvFileDeployment', {
destinationBucket: bucket,
retainOnDelete: false,
sources: [s3deployment.Source.asset(path.join(__dirname, '../demo-envfiles'))],
});

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f50f928 into master Jan 14, 2021
@mergify mergify bot deleted the epolon/botocore-unvending-requests branch January 14, 2021 13:24
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a86c278
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3-deployment contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(s3-deployment): handler uses deprecated botocore API
5 participants