-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3-deployment): stop using deprecated API's that will cause breakage post 01/31/21 #12491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Updated snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Maybe change the title to something a bit better. Something like 'stop using deprecated botocore APIs'. The title as-is will make little sense to customers reading the changelog.
@@ -711,21 +711,21 @@ | |||
"Code": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This integ test uses BucketDeployment
, hence the asset changes.
aws-cdk/packages/@aws-cdk/aws-ecs/test/ec2/integ.environment-file.ts
Lines 48 to 52 in 54f0ac6
const envFileDeployment = new s3deployment.BucketDeployment(stack, 'EnvFileDeployment', { | |
destinationBucket: bucket, | |
retainOnDelete: false, | |
sources: [s3deployment.Source.asset(path.join(__dirname, '../demo-envfiles'))], | |
}); |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
We currently use deprecated API's from the Lambda runtime that will be removed on January 30 2021.
This PR replaces those API usages with direct
urllib
usage, which is a built-in module available in any python installation.Fixes #12219
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license