feat(eks): Pass bootstrap.sh args to avoid DescribeCluster call and make nodes join the cluster faster #12659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-eks
anguslees
force-pushed
the
eks-bootstrap-args
branch
3 times, most recently
from
0de3128 to
76d4f66
Compare
anguslees
force-pushed
the
eks-bootstrap-args
branch
from
76d4f66 to
484af9e
Compare
iliapolo
reviewed
Feb 10, 2021
iliapolo
added
the
response-requested
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
the
closing-soon
|
dont close |
github-actions
bot
removed
closing-soon
iliapolo
reviewed
Feb 16, 2021
iliapolo
added
the
response-requested
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
the
closing-soon
|
@anguslees Are you still keeping an eye out on this PR? |
github-actions
bot
removed
closing-soon
anguslees
force-pushed
the
eks-bootstrap-args
branch
2 times, most recently
from
aba42bd to
aabeaf0
Compare
iliapolo
previously requested changes
Apr 2, 2021
Pass sufficient information to bootstrap.sh in ASG user-data, to prevent it from making a DescribeCluster AWS API call. This per-node API call can become an issue in large clusters, and we already have all the information to avoid it.
anguslees
force-pushed
the
eks-bootstrap-args
branch
from
aabeaf0 to
c95bc09
Compare
iliapolo
changed the title
iliapolo
previously approved these changes
Apr 15, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
added
pr/do-not-merge
iliapolo
approved these changes
Apr 15, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…ake nodes join the cluster faster (aws#12659) Pass sufficient information to bootstrap.sh in ASG user-data, to prevent it from making a DescribeCluster AWS API call. This per-node API call can become an issue in large clusters, and we already have all the information to avoid it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass sufficient information to bootstrap.sh in ASG user-data, to
prevent it from making a DescribeCluster AWS API call. This per-node
API call can become an issue in large clusters, and we already have
all the information to avoid it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license