Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfront): add support for TrustedKeyGroups in Distribution and CloudFrontWebDistribution #12847

Merged
merged 13 commits into from
Feb 4, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Feb 3, 2021

@njlynch Closes #11791

https://media3.giphy.com/media/3o7aCWJavAgtBzLWrS/giphy.gif


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 3, 2021

@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Feb 3, 2021
@robertd robertd force-pushed the robertd/cloudfront-keygroups-integration branch from 70ac3af to 51d8dd0 Compare February 3, 2021 16:02
@robertd robertd marked this pull request as ready for review February 4, 2021 14:04
njlynch
njlynch previously requested changes Feb 4, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo. A couple of minor nitpicks, and then this is good to go.

@mergify mergify bot dismissed njlynch’s stale review February 4, 2021 17:38

Pull request has been modified.

Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yay!

@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e92ec54
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 349a6e2 into aws:master Feb 4, 2021
@robertd robertd deleted the robertd/cloudfront-keygroups-integration branch February 4, 2021 19:58
@ClaudenirFreitas
Copy link

Hi all, I'm trying to use this feature in the latest version (1.88.0) but I didn't find the code there... is it everything ok?
Thanks in advance

@njlynch
Copy link
Contributor

njlynch commented Feb 8, 2021

@ClaudenirFreitas - This was merged in after the 1.88.0 release; it will go out with the next release.

@ClaudenirFreitas
Copy link

Perfect, thanks @njlynch !

NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
…d CloudFrontWebDistribution (aws#12847)


@njlynch Closes aws#11791

https://media3.giphy.com/media/3o7aCWJavAgtBzLWrS/giphy.gif

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(CloudFront): Support TrustedSigners & Key Groups
4 participants