-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudfront): add support for TrustedKeyGroups in Distribution and CloudFrontWebDistribution #12847
feat(cloudfront): add support for TrustedKeyGroups in Distribution and CloudFrontWebDistribution #12847
Conversation
…d CloudFrontWebDistribution
70ac3af
to
51d8dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo. A couple of minor nitpicks, and then this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Yay!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Hi all, I'm trying to use this feature in the latest version (1.88.0) but I didn't find the code there... is it everything ok? |
@ClaudenirFreitas - This was merged in after the 1.88.0 release; it will go out with the next release. |
Perfect, thanks @njlynch ! |
…d CloudFrontWebDistribution (aws#12847) @njlynch Closes aws#11791 https://media3.giphy.com/media/3o7aCWJavAgtBzLWrS/giphy.gif ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@njlynch Closes #11791
https://media3.giphy.com/media/3o7aCWJavAgtBzLWrS/giphy.gif
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license