Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate-manager: CertificateRequestorFunction uses soon to be EOL Node.js 10.3 runtime #12871

Closed
clementallen opened this issue Feb 4, 2021 · 4 comments
Assignees
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.

Comments

@clementallen
Copy link
Contributor

clementallen commented Feb 4, 2021

❓ CertificateRequestorFunction uses soon to be EOL Node.js 10.3 runtime

The Question

I know Node.js 10.x is still supported by AWS Lambda but with the official EOL given by Node.js of 30th April 2021 is it worth updating to Node.js 12.x or 14.x now?

Node.js release timeline: https://nodejs.org/en/about/releases/

image

Environment

  • CDK CLI Version: 1.88.0
  • Module Version: 1.88.0
  • Node.js Version: N/A
  • OS: All
  • Language (Version): All

Other information

I am happy to raise a Merge Request with this change but wanted to check it would be worthwhile first.

@clementallen clementallen added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 4, 2021
@NGL321 NGL321 self-assigned this Feb 22, 2021
@tom-mi
Copy link

tom-mi commented Mar 8, 2021

Thanks for bringing this up!
Instead of upgrading to v12 what do you think about upgrading to v14 now so we don't have the same issue again next year?

@github-actions github-actions bot added the @aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager label Mar 8, 2021
@njlynch
Copy link
Contributor

njlynch commented Mar 9, 2021

@clementallen - Thanks for bringing this up! A PR would be much appreciated. I agree with @tom-mi that we should jump up to v14.

@njlynch
Copy link
Contributor

njlynch commented Mar 9, 2021

Actually, it looks like #13488 is already handling this. You can track the fix there.

Thanks for the issue!

@njlynch njlynch closed this as completed Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-certificatemanager Related to Amazon Certificate Manager guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants