fix(rds): proxy cannot connect to cluster/instance #12953
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-rds
There was a problem hiding this comment.
Our contribution guide suggests using lower case for PR titles. I suppose this is in response to the guideline in conventional commits.
This should likely be "fix(rds): proxy cannot connect to cluster/instance"
By default, when creating a Proxy, we were not creating a Security Group for it, and because of that, the Proxy could not connect to the Cluster/Instance.
skinny85
force-pushed
the
fix/rds-proxy-connectivity
branch
from
236cbfd to
4bb2352
Compare
|
@nija-at thanks for the review! This is ready for another round. |
skinny85
changed the title
| @@ -138,6 +136,22 @@ export = { | |||
| DBInstanceIdentifiers: ABSENT, | |||
| TargetGroupName: 'default', | |||
| })); | |||
| expect(stack).to(haveResourceLike('AWS::EC2::SecurityGroupIngress', { | |||
There was a problem hiding this comment.
I would much prefer to see a separate test case for these. Something like 'db proxy configures the tcp security ingress'. This keeps test cases small and understandable, rather than a large set of 'expects' and fewer test cases.
| @@ -221,6 +236,10 @@ export = { | |||
| 'my-cluster', | |||
| ], | |||
| })); | |||
| expect(stack).to(haveResourceLike('AWS::EC2::SecurityGroup', { | |||
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
By default, when creating a Proxy, we were not creating a Security Group for it, and because of that, the Proxy could not connect to the Cluster/Instance. See docs at: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/rds-proxy.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By default, when creating a Proxy, we were not creating a Security Group for it, and because of that, the Proxy could not connect to the Cluster/Instance. See docs at: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/rds-proxy.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
fixes #8919 |
By default, when creating a Proxy,
we were not creating a Security Group for it,
and because of that, the Proxy could not connect to the Cluster/Instance.
See docs at: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/rds-proxy.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license