fix(cfn-diff): handle Fn::If inside policies and statements #12975
Conversation
|
|
skinny85
force-pushed
the
fix/diff-for-iam-policies
branch
from
fd3bb1c
to
bfbcd8f
Compare
|
@rix0rrr I know you already approved this one (thanks!), but do you mind taking another look? As it turns out, the I did a refactoring to be able to control how the rendering of a |
cloudformation-diff assumes the policies and statements it encounters are simple JSON objects. However, in reality, everywhere that simple object can be used, the Fn::If function can be used as well. Add code that handles that eventuality. Fixes aws#12887
skinny85
force-pushed
the
fix/diff-for-iam-policies
branch
from
bfbcd8f
to
482b95f
Compare
|
@rix0rrr included your latest comments, please re-review when you have a chance! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
cloudformation-diff assumes the policies and statements it encounters are simple JSON objects. However, in reality, everywhere that simple object can be used, the Fn::If function can be used as well. Add code that handles that eventuality. Fixes #12887 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cloudformation-diff assumes the policies and statements it encounters are simple JSON objects.
However, in reality, everywhere that simple object can be used,
the Fn::If function can be used as well.
Add code that handles that eventuality.
Fixes #12887
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license