fix(cfn-diff): correctly handle version strings like '0.0.0' #13022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, our cloudformation-diff interprets all version strings like '0.2.3' as just 0, which means diff misses any changes to those kind of resources. Make sure that returning the number 0 only happens for strings that are actually equal to '0'. Fixes aws#13016
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NetaNir
approved these changes
Feb 13, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
Turns out, our cloudformation-diff interprets all version strings like '0.2.3' as just 0, which means diff misses any changes to those kind of resources. Make sure that returning the number 0 only happens for strings that are actually equal to '0'. Fixes aws#13016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, our cloudformation-diff interprets all version strings like '0.2.3' as just 0,
which means diff misses any changes to those kind of resources.
Make sure that returning the number 0 only happens for strings that are actually equal to '0'.
Fixes #13016
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license