Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): Deployment fails for the first deployment in an account #13103

Merged
merged 6 commits into from
Feb 18, 2021

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Feb 17, 2021

Give our creation role the necessary ec2 permissions to allow creating clusters on environments without an existing SLR.

The specific operations were taken from the managed policies of the SLRs. Comments inline.

See #9027 (comment) for more context.

Fixes #9027.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 17, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 17, 2021
@iliapolo iliapolo marked this pull request as ready for review February 17, 2021 11:10
@iliapolo iliapolo requested a review from eladb February 17, 2021 11:10
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Feb 17, 2021
@iliapolo
Copy link
Contributor Author

@eladb take a look?

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 36ac496
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e042879 into master Feb 18, 2021
@mergify mergify bot deleted the epolon/eks-fails-first-deploy branch February 18, 2021 07:08
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
…s#13103)

Give our creation role the necessary `ec2` permissions to allow creating clusters on environments without an existing SLR. 

The specific operations were taken from the managed policies of the SLRs. Comments inline.

See aws#9027 (comment) for more context.

Fixes aws#9027.  

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
…3103)

Give our creation role the necessary `ec2` permissions to allow creating clusters on environments without an existing SLR. 

The specific operations were taken from the managed policies of the SLRs. Comments inline.

See #9027 (comment) for more context.

Fixes #9027.  

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] ec2:DescribeVpcs permission is missing when creating clusters
3 participants