feat(core): customize bundling output packaging #13152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
|
|
|
@eladb have you seen this? |
|
No. I'll take a look today. Thanks |
eladb
reviewed
Feb 24, 2021
This was referenced Mar 6, 2021
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #13076 after #13131. The fix is
7b3d829(#13152).If the bundling output contains a single archive file (zip or jar), upload it
as-is to S3 without zipping it.
Allow to customize this behavior with
bundling.outputType:NOT_ARCHIVED: The bundling output will always be zipped and uploaded to S3.ARCHIVED: The bundling output will not be zipped. Bundling will fail ifthe bundling output doesn't contain a single archive file.
AUTO_DISCOVER: If the bundling output contains a single archive file (zip or jar) itwill not be zipped. Otherwise it will be zipped. This is the default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license