Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codebuild): allow FILE_PATH webhook filter for BitBucket #13186

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

leimd
Copy link
Contributor

@leimd leimd commented Feb 22, 2021

Remove restrictions around FILE_PATH for Bitbucket sources as this is
supported by CloudFormation now.

Closes #13175


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 22, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Feb 22, 2021
Remove restrictions around FILE_PATH for Bitbucket sources as this is
supported by CloudFormation now.

closes aws#13175
@leimd leimd force-pushed the fix-codebuild-bitbucket-file-path branch from 0805385 to 5dc610a Compare February 22, 2021 02:32
@leimd
Copy link
Contributor Author

leimd commented Feb 23, 2021

@skinny85 This PR is ready! Let me know if you need me to make any changes.

@skinny85
Copy link
Contributor

skinny85 commented Mar 2, 2021

Sorry for the late response @leimd , I was on vacation. I'll look at the PR this week.

Thanks for the contribution!

@skinny85 skinny85 changed the title fix(codebuild): Allow Bitbucket FILE_PATH filter fix(codebuild): allow Bitbucket FILE_PATH filter Mar 3, 2021
@skinny85 skinny85 changed the title fix(codebuild): allow Bitbucket FILE_PATH filter fix(codebuild): allow FILE_PATHwebhook filter for BitBucket Mar 3, 2021
@skinny85 skinny85 changed the title fix(codebuild): allow FILE_PATHwebhook filter for BitBucket fix(codebuild): allow FILE_PATH webhook filter for BitBucket Mar 3, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution @leimd!

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: acd160b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cbed348 into aws:master Mar 3, 2021
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
Remove restrictions around FILE_PATH for Bitbucket sources as this is
supported by CloudFormation now.

Closes aws#13175


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codebuild Bitbucket Source FilePath trigger Not Allowed in CDK
3 participants