Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit: make JSON the default output (and use it for "deploy") #1323

Closed
eladb opened this issue Dec 11, 2018 · 1 comment
Closed

Toolkit: make JSON the default output (and use it for "deploy") #1323

eladb opened this issue Dec 11, 2018 · 1 comment
Assignees
Labels
feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md package/tools Related to AWS CDK Tools or CLI

Comments

@eladb
Copy link
Contributor

eladb commented Dec 11, 2018

We have been seeing some issues around the YAML library we've been using to produce the synthesized output (e.g. #1309, #1100, #876). We are working wit the maintainer to improve the library. However, there is no real reason to use YAML as a wire format (and a default) for the toolkit because mostly it's consumed by machines and not humans.

To avoid further grief, let's move our default to use JSON instead of YAML. We can leave YAML as an option.

@eladb eladb added enhancement good first issue Related to contributions. See CONTRIBUTING.md @aws-cdk/aws-route53 Related to Amazon Route 53 package/tools Related to AWS CDK Tools or CLI and removed @aws-cdk/aws-route53 Related to Amazon Route 53 ❓ question labels Dec 17, 2018
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@eladb
Copy link
Contributor Author

eladb commented Oct 2, 2019

This is done.

@eladb eladb closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

3 participants