Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): cannot trigger multiple Lambdas from the same Rule #13260

Merged
merged 5 commits into from
Feb 25, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 24, 2021

The permissions required to actually trigger the Lambda would only
be added to the first target, not to any of the others.

Fixes #13231.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The permissions required to actually trigger the Lambda would only
be added to the first target, not to any of the others.

Fixes #13231.
@rix0rrr rix0rrr requested a review from a team February 24, 2021 17:34
@rix0rrr rix0rrr self-assigned this Feb 24, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 24, 2021

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Feb 24, 2021

Draft PR, still need to add a test but wanted to get the build rolling first.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 24, 2021
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Feb 24, 2021
@rix0rrr rix0rrr marked this pull request as ready for review February 25, 2021 10:01
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8c67bb0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c8c1762 into master Feb 25, 2021
@mergify mergify bot deleted the huijbers/multiple-events-targets branch February 25, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-events): Rule.addTarget() not configuring all lambda targets with event trigger
3 participants