Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudformation): update integration tests with description parameter for custom resources #13276

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Feb 25, 2021

Integration test in core module requires that any custom description parameter integration tests should be done in cloudformation module.

https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/core/test/integration.custom-resources.readme

+--------------------------------------------------------------------------+
| Since cdk-integ depends on cdk which depends on @aws-cdk/core (as a "dev |
| dependency"), this integration test has been added to the package        |
| @aws-cdk/aws-cloudformation under `test/integ.core-custom-resources.ts`  |
+--------------------------------------------------------------------------+

Depends on #13275


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 25, 2021

@github-actions github-actions bot added @aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/custom-resources Related to AWS CDK Custom Resources labels Feb 25, 2021
@robertd robertd marked this pull request as draft February 25, 2021 06:16
@robertd robertd marked this pull request as ready for review February 25, 2021 14:21
mergify bot pushed a commit that referenced this pull request Feb 25, 2021
…3275)

Required by #13277 and #13276 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr
rix0rrr previously approved these changes Feb 25, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really mind shipping this, but would you mind elaborating on the motivation somewhat?

@robertd
Copy link
Contributor Author

robertd commented Feb 25, 2021

I don't really mind shipping this, but would you mind elaborating on the motivation somewhat?

Sorry about that @rix0rrr .... Updated the original PR.

@mergify mergify bot dismissed rix0rrr’s stale review February 25, 2021 15:10

Pull request has been modified.

@robertd
Copy link
Contributor Author

robertd commented Feb 25, 2021

@rix0rrr I wasn't sure if cross-module commits are allowed so I split them into two separate ones.

@robertd robertd changed the title chore(cloudformation): Update integration tests with description parameter for custom resources chore(cloudformation): update integration tests with description parameter for custom resources Feb 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d2e4692
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/custom-resources Related to AWS CDK Custom Resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants