fix(lambda-nodejs): paths with spaces break esbuild #13312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Problem] Paths with spaces break ESBuild on Windows. [Solution] Add double quotes around the input paths for the ESBuild command. [Testing] Updated unit tests and confirmed in my own package this fix works.
|
|
|
Looks like I forgot to remove the Windows path replacement with this change too. Will add that in really fast since this won't fully fix it without that. |
[Problem] Need to revert the previous change that escaped spaces for Windows builds, since this did not actually fix the issue. [Solution] Removed previous code changes. [Testing] Updated unit tests and manually tested on another project.
eladb
changed the title
eladb
approved these changes
Feb 28, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Paths with spaces break ESBuild on Windows.
Solution: Add double quotes around the input paths for the ESBuild command.
Testing: Updated unit tests and confirmed in my own package this fix works.
Closes #13311
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license