fix(cloudfront): cannot add two EdgeFunctions with same aliases #13324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to add two EdgeFunctions to the same stack, and then giving both the same alias (e.g., 'prod', 'live') results in an ID conflict. This is because the aliases are being added to the scope of the shared EdgeFunction stack, rather than the scope of the Function itself. fixes #13237
|
|
nija-at
approved these changes
Mar 1, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
cornerwings
pushed a commit
to cornerwings/aws-cdk
that referenced
this pull request
Mar 8, 2021
…13324) Attempting to add two EdgeFunctions to the same stack, and then giving both the same alias (e.g., 'prod', 'live') results in an ID conflict. This is because the aliases are being added to the scope of the shared EdgeFunction stack, rather than the scope of the Function itself. Note - Also took the opportunity to simplify one of the integ tests to deploy to a single distribution. fixes aws#13237 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to add two EdgeFunctions to the same stack, and then giving both the
same alias (e.g., 'prod', 'live') results in an ID conflict. This is because the
aliases are being added to the scope of the shared EdgeFunction stack, rather
than the scope of the Function itself.
Note - Also took the opportunity to simplify one of the integ tests to deploy to a
single distribution.
fixes #13237
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license